Skip to content

Commit 0f68b38

Browse files
Fixed issue with Generated property defaulting to Public if getter nor setter was passed in
1 parent 1804ffd commit 0f68b38

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

src/ThunderDesign.Net-PCL.SourceGenerators/UnifiedPropertyGenerator.cs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -277,9 +277,10 @@ static string GetWidestAccessibility(object getter, object setter)
277277
var getter = args.Length > 4 ? args[4].Value : null;
278278
var setter = args.Length > 5 ? args[5].Value : null;
279279

280-
var getterStr = ToAccessorString(getter);
281-
var setterStr = ToAccessorString(setter);
282-
var propertyAccessibilityStr = ToAccessorString(GetWidestAccessibility(getter, setter));
280+
// If getter/setter are not specified, default to "Public"
281+
var getterStr = ToAccessorString(getter ?? "Public");
282+
var setterStr = ToAccessorString(setter ?? "Public");
283+
var propertyAccessibilityStr = ToAccessorString(GetWidestAccessibility(getter ?? "Public", setter ?? "Public"));
283284

284285
var lockerArg = threadSafe ? "_Locker" : "null";
285286
var notifyArg = notify ? "true" : "false";
@@ -346,9 +347,10 @@ static string GetWidestAccessibility(object getter, object setter)
346347
var getter = args.Length > 2 ? args[2].Value : null;
347348
var setter = args.Length > 3 ? args[3].Value : null;
348349

349-
var getterStr = ToAccessorString(getter);
350-
var setterStr = ToAccessorString(setter);
351-
var propertyAccessibilityStr = ToAccessorString(GetWidestAccessibility(getter, setter));
350+
// If getter/setter are not specified, default to "Public"
351+
var getterStr = ToAccessorString(getter ?? "Public");
352+
var setterStr = ToAccessorString(setter ?? "Public");
353+
var propertyAccessibilityStr = ToAccessorString(GetWidestAccessibility(getter ?? "Public", setter ?? "Public"));
352354

353355
var lockerArg = threadSafe ? "_Locker" : "null";
354356
if (readOnly)

0 commit comments

Comments
 (0)