Fix C1090 PDB race and remaining C4244 iota warnings for clean /W4 build

Author: JkarVN

CMakeLists.txt

@@ -16,7 +16,7 @@ target_include_directories(pcg-cpp INTERFACE
 target_compile_features(pcg-cpp INTERFACE cxx_std_11)
 
 if(MSVC)
-    target_compile_options(pcg-cpp INTERFACE /W4) # /Wall is extremely noisy on MSVC
+    target_compile_options(pcg-cpp INTERFACE /W4 /FS) # /FS fixes C1090 PDB race conditions
 else()
     target_compile_options(pcg-cpp INTERFACE -Wall -Wextra -Wpedantic)
 endif()

sample/pcg-demo.cpp

@@ -149,15 +149,15 @@ int main(int argc, char** argv)
         rng_copy = rng;
         enum { SUITS = 4, NUMBERS = 13, CARDS = 52 };
         char cards[CARDS];
-        iota(begin(cards), end(cards), 0);
+        iota(begin(cards), end(cards), char(0));
         std::shuffle(begin(cards), end(cards), rng);
         auto std_shuffle_steps = rng - rng_copy;
 
         /* Restore RNG and deal again using pcg_extras::shuffle, which follows
          * the algorithm for shuffling that most programmers would expect.
          */      
         rng = rng_copy;
-        iota(begin(cards), end(cards), 0);
+        iota(begin(cards), end(cards), char(0));
         pcg_extras::shuffle(begin(cards), end(cards), rng);
         auto my_shuffle_steps = rng - rng_copy;
 

test-high/pcg-test-noadvance.cpp

@@ -136,7 +136,7 @@ int main(int argc, char** argv)
          */      
         enum { SUITS = 4, NUMBERS = 13, CARDS = 52 };
         char cards[CARDS];
-        iota(begin(cards), end(cards), 0);
+        iota(begin(cards), end(cards), char(0));
         pcg_extras::shuffle(begin(cards), end(cards), rng);
 
         /* Output the shuffled deck */

test-high/pcg-test.cpp

@@ -148,7 +148,7 @@ int main(int argc, char** argv)
          */      
         enum { SUITS = 4, NUMBERS = 13, CARDS = 52 };
         char cards[CARDS];
-        iota(begin(cards), end(cards), 0);
+        iota(begin(cards), end(cards), char(0));
         pcg_extras::shuffle(begin(cards), end(cards), rng);
 
         /* Output the shuffled deck */