Add process_options to options tsting

Author: rocky

setup.cfg

@@ -71,3 +71,8 @@ per-file-ignores =
     # Ignore undefined name errors in "expectation" test Python code.
     # These files get exec'd in an environment that defines the variables.
     server/tests/files/expectations/*.py:F821
+
+[tool.pylsp-mypy]
+enabled = true
+live_mode = true
+exclude = ["trepan/version.py", "tests/*"]

test/unit/test_options.py

@@ -1,9 +1,16 @@
 """Unit test for trepan.options"""
 
-from trepan.options import process_options
+from test.unit.cmdhelper import setup_unit_test_debugger
+
+from trepan.options import postprocess_options, process_options
 
 
 def test_options():
+    """
+    Test trepan.options.process_options() and trepan.options.postprocess.
+    """
+
+    # Setup.
     option_key_set = {
         "annotate",
         "basename",
@@ -30,19 +37,30 @@ def test_options():
         "style",
         "target",
     }
+    dbg, _ = setup_unit_test_debugger()
     dbg_opts_set = {"proc_opts", "from_ipython"}
 
+    # Test with no options. See that we have the some expected
+    # keys getting set.
     opts, dbg_opts, sys_argv = process_options("1.0", [__file__])
     diff_set = option_key_set - set(vars(opts).keys())
     assert diff_set == set(), "expecting at least these options keys set"
     assert (
         dbg_opts_set - set(dbg_opts.keys())
     ) == set(), "expecting at least these processor keys set"
 
+    # Try with more than one option, a boolean option and a string option.
     arg_str = f"{__file__} --fntrace --cd=/tmp"
     opts, dbg_opts, sys_argv = process_options("1.1", arg_str.split())
     assert opts.cd == "/tmp"
+    postprocess_options(dbg, opts)
+    assert dbg.settings["printset"] == frozenset(
+        ["c_call", "c_return", "call", "return"]
+    )
 
-    arg_str = f"{__file__} --style=emacs"
-    opts, dbg_opts, sys_argv = process_options("1.2", arg_str.split())
-    assert opts.style == "emacs"
+    # Try with an invalid style option and see that it is
+    # rejected in postprocess option
+    arg_str = f"{__file__} --style=fafdsaXYZZY"
+    opts, dbg_opts, sys_argv = process_options("1.3", arg_str.split())
+    postprocess_options(dbg, opts)
+    assert dbg.settings["style"] is None

trepan/options.py

@@ -20,6 +20,8 @@
 import sys
 from optparse import OptionParser
 
+from pygments.styles import STYLE_MAP
+
 import trepan.api
 from trepan.api import debugger_on_post_mortem
 from trepan.clifns import path_expanduser_abs
@@ -380,10 +382,16 @@ def postprocess_options(dbg, opts):
     else:
         dbg.settings["highlight"] = "plain"
 
+    dbg.settings["style"] = None
     if getattr(opts, "style") and opts.style != "none":
-        dbg.settings["style"] = opts.style
-    else:
-        dbg.settings["style"] = None
+        style_names = sorted(list(STYLE_MAP.keys()))
+        if opts.style in style_names:
+            dbg.settings["style"] = opts.style
+        else:
+            sys.stderr.write(
+                f"""Pygments style "{opts.style}" listed. --style option ignored.\n"""
+                f"""Use 'set style" to see valid style and change style.\n"""
+            )
 
     # Normally we want to set trepan.api.debugger_obj so that one can
     # put trepan.debugger breakpoints in a program and not have more