fix(test): make tag tests compatible with strict mode

Author: Chemaclass

tests/acceptance/bashunit_tag_test.sh

@@ -79,7 +79,7 @@ function test_tag_nonexistent_runs_zero_tests() {
   local test_file=./tests/acceptance/fixtures/test_bashunit_with_tags.sh
   local output
 
-  output=$(./bashunit --no-parallel --env "$TEST_ENV_FILE" --tag nonexistent "$test_file" 2>&1)
+  output=$(./bashunit --no-parallel --env "$TEST_ENV_FILE" --tag nonexistent "$test_file" 2>&1) || true
 
   assert_contains "0 total" "$output"
 }

tests/unit/helpers_tag_test.sh

@@ -39,69 +39,77 @@ function test_function_matches_tags_include_match() {
   local include_tags="slow"
   local exclude_tags=""
 
-  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags"
-  assert_successful_code "$?"
+  local exit_code=0
+  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags" || exit_code=$?
+  assert_same 0 "$exit_code"
 }
 
 function test_function_matches_tags_include_no_match() {
   local tags="fast"
   local include_tags="slow"
   local exclude_tags=""
 
-  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags"
-  assert_general_error "$?"
+  local exit_code=0
+  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags" || exit_code=$?
+  assert_same 1 "$exit_code"
 }
 
 function test_function_matches_tags_exclude_match() {
   local tags="slow,database"
   local include_tags=""
   local exclude_tags="slow"
 
-  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags"
-  assert_general_error "$?"
+  local exit_code=0
+  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags" || exit_code=$?
+  assert_same 1 "$exit_code"
 }
 
 function test_function_matches_tags_exclude_wins_over_include() {
   local tags="slow,database"
   local include_tags="database"
   local exclude_tags="slow"
 
-  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags"
-  assert_general_error "$?"
+  local exit_code=0
+  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags" || exit_code=$?
+  assert_same 1 "$exit_code"
 }
 
 function test_function_matches_tags_no_tags_with_include_filter() {
   local tags=""
   local include_tags="slow"
   local exclude_tags=""
 
-  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags"
-  assert_general_error "$?"
+  local exit_code=0
+  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags" || exit_code=$?
+  assert_same 1 "$exit_code"
 }
 
 function test_function_matches_tags_no_tags_with_exclude_filter() {
   local tags=""
   local include_tags=""
   local exclude_tags="slow"
 
-  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags"
-  assert_successful_code "$?"
+  local exit_code=0
+  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags" || exit_code=$?
+  assert_same 0 "$exit_code"
 }
 
 function test_function_matches_tags_multiple_include_or_logic() {
   local tags="fast"
   local include_tags="slow,fast"
   local exclude_tags=""
 
-  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags"
-  assert_successful_code "$?"
+  local exit_code=0
+  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags" || exit_code=$?
+  assert_same 0 "$exit_code"
 }
 
 function test_function_matches_tags_multiple_exclude_or_logic() {
   local tags="fast"
   local include_tags=""
   local exclude_tags="slow,fast"
 
-  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags"
-  assert_general_error "$?"
+  local exit_code=0
+  bashunit::helper::function_matches_tags "$tags" "$include_tags" "$exclude_tags" || exit_code=$?
+  assert_same 1 "$exit_code"
 }