fix(doubles): use real mktemp path to prevent mock interference (#603)

Author: Chemaclass

CHANGELOG.md

@@ -29,6 +29,7 @@
 - Batch coverage recording with in-memory buffering
 
 ### Fixed
+- Mocking `mktemp` no longer breaks spy creation (#602)
 - JUnit XML report now conforms to the standard schema
     - Remove non-standard `passed`, `incomplete`, `snapshot` attributes from `<testsuite>` and `status`, `assertions` from `<testcase>`
     - Add `errors="0"` attribute and `<failure>`/`<skipped>` child elements per the JUnit spec

src/assert.sh

@@ -384,8 +384,8 @@ function assert_exec() {
   done
 
   local stdout_file stderr_file
-  stdout_file=$(mktemp)
-  stderr_file=$(mktemp)
+  stdout_file=$("$MKTEMP")
+  stderr_file=$("$MKTEMP")
 
   eval "$cmd" >"$stdout_file" 2>"$stderr_file"
   local exit_code=$?

src/env.sh

@@ -271,10 +271,11 @@ EXIT_CODE_STOP_ON_FAILURE=4
 TEMP_DIR_PARALLEL_TEST_SUITE="${TMPDIR:-/tmp}/bashunit/parallel/${_BASHUNIT_OS:-Unknown}/$(bashunit::random_str 8)"
 TEMP_FILE_PARALLEL_STOP_ON_FAILURE="$TEMP_DIR_PARALLEL_TEST_SUITE/.stop-on-failure"
 TERMINAL_WIDTH="$(bashunit::env::find_terminal_width)"
-FAILURES_OUTPUT_PATH=$(mktemp)
-SKIPPED_OUTPUT_PATH=$(mktemp)
-INCOMPLETE_OUTPUT_PATH=$(mktemp)
 CAT="$(command -v cat)"
+MKTEMP="$(command -v mktemp)"
+FAILURES_OUTPUT_PATH=$("$MKTEMP")
+SKIPPED_OUTPUT_PATH=$("$MKTEMP")
+INCOMPLETE_OUTPUT_PATH=$("$MKTEMP")
 
 # Initialize temp directory once at startup for performance
 BASHUNIT_TEMP_DIR="${TMPDIR:-/tmp}/bashunit/tmp"

src/globals.sh

@@ -48,7 +48,7 @@ function bashunit::temp_file() {
     # We're at script level (e.g., in set_up_before_script) - use script ID
     test_prefix="${BASHUNIT_CURRENT_SCRIPT_ID}_"
   fi
-  mktemp "$BASHUNIT_TEMP_DIR/${test_prefix}${prefix}.XXXXXXX"
+  "$MKTEMP" "$BASHUNIT_TEMP_DIR/${test_prefix}${prefix}.XXXXXXX"
 }
 
 function bashunit::temp_dir() {
@@ -61,7 +61,7 @@ function bashunit::temp_dir() {
     # We're at script level (e.g., in set_up_before_script) - use script ID
     test_prefix="${BASHUNIT_CURRENT_SCRIPT_ID}_"
   fi
-  mktemp -d "$BASHUNIT_TEMP_DIR/${test_prefix}${prefix}.XXXXXXX"
+  "$MKTEMP" -d "$BASHUNIT_TEMP_DIR/${test_prefix}${prefix}.XXXXXXX"
 }
 
 function bashunit::cleanup_testcase_temp_files() {

src/runner.sh

@@ -890,10 +890,10 @@ function bashunit::runner::parse_result_parallel() {
   fi
 
   local unique_test_result_file
-  if unique_test_result_file=$(mktemp -p "$test_suite_dir" "$template" 2>/dev/null); then
+  if unique_test_result_file=$("$MKTEMP" -p "$test_suite_dir" "$template" 2>/dev/null); then
     true
   else
-    unique_test_result_file=$(mktemp "$test_suite_dir/$template")
+    unique_test_result_file=$("$MKTEMP" "$test_suite_dir/$template")
   fi
   mv "$unique_test_result_file" "${unique_test_result_file}.result"
   unique_test_result_file="${unique_test_result_file}.result"

tests/functional/doubles_test.sh

@@ -89,3 +89,20 @@ function test_spy_commands_called_once_when_executing_a_sourced_function() {
   assert_have_been_called_times 1 awk
   assert_have_been_called_times 1 head
 }
+
+function test_mock_mktemp_does_not_break_spy_creation() {
+  # shellcheck disable=SC2329
+  mock_mktemp() {
+    echo "/tmp/mocked_temp_file"
+  }
+
+  bashunit::mock mktemp mock_mktemp
+
+  bashunit::spy rm
+
+  rm -f "/tmp/mocked_temp_file"
+
+  assert_have_been_called rm
+  assert_have_been_called_times 1 rm
+  assert_have_been_called_with rm "-f" "/tmp/mocked_temp_file"
+}