test(project): Add another multiple-task / tag handling case

Author: maxreichmann

packages/project/test/fixtures/application.a/custom-tasks-2/custom-task-0.js

@@ -0,0 +1,19 @@
+let buildRanOnce;
+module.exports = async function ({
+	workspace, taskUtil,
+	options: {projectNamespace}
+}) {
+	console.log("Custom task 0 executed");
+
+	// Read a file to trigger execution of this task:
+	const testJS = await workspace.byPath(`/resources/${projectNamespace}/test.js`);
+
+	if (buildRanOnce != true) {
+		console.log("Flag NOT set -> We are in #1 Build still");
+		buildRanOnce = true;
+		taskUtil.setTag(testJS, taskUtil.STANDARD_TAGS.IsDebugVariant);
+	} else {
+		console.log("Flag set -> We are in #2 Build");
+		taskUtil.setTag(testJS, taskUtil.STANDARD_TAGS.OmitFromBuildResult);
+	}
+};

packages/project/test/fixtures/application.a/custom-tasks-2/custom-task-1.js

@@ -0,0 +1,25 @@
+let buildRanOnce;
+module.exports = async function ({
+	workspace, taskUtil,
+	options: {projectNamespace}
+}) {
+	console.log("Custom task 1 executed");
+
+	// Read a file to trigger execution of this task:
+	const testJS = await workspace.byPath(`/resources/${projectNamespace}/test.js`);
+
+	if (buildRanOnce != true) {
+		console.log("Flag NOT set -> We are in #1 Build still");
+		buildRanOnce = true;
+		const tag = taskUtil.getTag(testJS, taskUtil.STANDARD_TAGS.IsDebugVariant);
+		if (!tag) {
+			throw new Error("Tag set during #1 Build is not readable, which is UNEXPECTED.");
+		}
+	} else {
+		console.log("Flag set -> We are in #2 Build");
+		const tag = taskUtil.getTag(testJS, taskUtil.STANDARD_TAGS.OmitFromBuildResult);
+		if (!tag) {
+			throw new Error("Tag set during #2 Build is not readable, which is UNEXPECTED.");
+		}
+	}
+};

packages/project/test/fixtures/application.a/ui5-multiple-customTasks-2.yaml

@@ -0,0 +1,27 @@
+---
+specVersion: "5.0"
+type: application
+metadata:
+  name: application.a
+builder:
+  customTasks:
+    - name: custom-task-0
+      afterTask: minify
+    - name: custom-task-1
+      afterTask: custom-task-0
+---
+specVersion: "5.0"
+kind: extension
+type: task
+metadata:
+  name: custom-task-0
+task:
+  path: custom-tasks-2/custom-task-0.js
+---
+specVersion: "5.0"
+kind: extension
+type: task
+metadata:
+  name: custom-task-1
+task:
+  path: custom-tasks-2/custom-task-1.js

packages/project/test/lib/build/ProjectBuilder.integration.js

@@ -319,6 +319,48 @@ test.serial("Build application.a (multiple custom tasks)", async (t) => {
 	});
 });
 
+test.serial.skip("Build application.a (multiple custom tasks 2)", async (t) => {
+	const fixtureTester = new FixtureTester(t, "application.a");
+	const destPath = fixtureTester.destPath;
+
+	// This test should cover a scenario with multiple custom tasks.
+	// Specifically, it's invalidating the task cache by only modifying tags on resources,
+	// but not the resources themselves.
+
+	// #1 build (no cache, no changes, with custom tasks)
+	// During this build, "custom-task-0" sets the tag "isDebugVariant" to test.js.
+	// "custom-task-1" checks if it's able to read this tag.
+	await fixtureTester.buildProject({
+		graphConfig: {rootConfigPath: "ui5-multiple-customTasks-2.yaml"},
+		config: {destPath, cleanDest: true},
+		assertions: {
+			projects: {
+				"application.a": {}
+			}
+		}
+	});
+
+
+	// #2 build (with cache, no changes, with custom tasks)
+	// During this build, "custom-task-0" sets a different tag to test.js (namely "OmitFromBuildResult").
+	// "custom-task-1" again checks if it's able to read this different tag.
+	// It's expected that both custom tasks are not getting skipped during this build,
+	// even though any resources weren't modified.
+	// FIXME: Currently, the entire build is skipped and therefore the custom tasks are not executed.
+	await fixtureTester.buildProject({
+		graphConfig: {rootConfigPath: "ui5-multiple-customTasks-2.yaml"},
+		config: {destPath, cleanDest: true},
+		assertions: {
+			projects: {
+				"application.a": {} // TODO: add non-relevant skippedTasks here, once the tag handling works
+			}
+		}
+	});
+
+	// Check that test.js is omitted from build output:
+	await t.throwsAsync(fs.readFile(`${destPath}/test.js`, {encoding: "utf8"}));
+});
+
 test.serial("Build library.d project multiple times", async (t) => {
 	const fixtureTester = new FixtureTester(t, "library.d");
 	const destPath = fixtureTester.destPath;