Skip to content

Commit bba86e6

Browse files
committed
refactor(project): ProjectBuilder cleanup, add UI5_BUILD_NO_WRITE param
1 parent 80ef248 commit bba86e6

2 files changed

Lines changed: 3 additions & 21 deletions

File tree

packages/project/lib/build/ProjectBuilder.js

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import OutputStyleEnum from "./helpers/ProjectBuilderOutputStyle.js";
1414
class ProjectBuilder {
1515
#log;
1616
#buildIsRunning = false;
17-
// #resourceChanges = new Map();
1817

1918
/**
2019
* Build Configuration
@@ -122,26 +121,9 @@ class ProjectBuilder {
122121
}
123122

124123
resourcesChanged(changes) {
125-
// if (!this.#resourceChanges.size) {
126-
// this.#resourceChanges = changes;
127-
// return;
128-
// }
129-
// for (const [project, resourcePaths] of changes.entries()) {
130-
// if (!this.#resourceChanges.has(project.getName())) {
131-
// this.#resourceChanges.set(project.getName(), []);
132-
// }
133-
// const projectChanges = this.#resourceChanges.get(project.getName());
134-
// projectChanges.push(...resourcePaths);
135-
// }
136-
137124
return this._buildContext.propagateResourceChanges(changes);
138125
}
139126

140-
// _flushResourceChanges() {
141-
// this._buildContext.propagateResurceChanges(this.#resourceChanges);
142-
// this.#resourceChanges = new Map();
143-
// }
144-
145127
async build({
146128
includedDependencies = [], excludedDependencies = [],
147129
}) {
@@ -188,7 +170,7 @@ class ProjectBuilder {
188170
const requestedProjects = this._determineRequestedProjects(
189171
includedDependencies, excludedDependencies, dependencyIncludes);
190172

191-
if (destPath && cleanDest) {
173+
if (cleanDest) {
192174
this.#log.info(`Cleaning target directory...`);
193175
await rmrf(destPath);
194176
}
@@ -293,7 +275,7 @@ class ProjectBuilder {
293275
pWrites.push(projectBuildContext.getBuildCache().writeCache());
294276
}
295277

296-
if (fsTarget && requestedProjects.includes(projectName)) {
278+
if (fsTarget && requestedProjects.includes(projectName) && !process.env.UI5_BUILD_NO_WRITE) {
297279
// Only write requested projects to target
298280
// (excluding dependencies that were required to be built, but not requested)
299281
this.#log.verbose(`Writing out files for project ${projectName}...`);

packages/project/lib/build/cache/ResourceRequestManager.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ class ResourceRequestManager {
8787
const registry = registries.get(node.getParentId());
8888
if (!registry) {
8989
throw new Error(`Missing tree registry for parent of node ID ${nodeId} of task ` +
90-
`'${this.#taskName}' of project '${this.#projectName}'`);
90+
`'${taskName}' of project '${projectName}'`);
9191
}
9292
const resourceIndex = parentResourceIndex.deriveTreeWithIndex(addedResourceIndex);
9393

0 commit comments

Comments
 (0)