Merge pull request #778 from lesserwhirls/pubFix

[5.x]: Fix root publishing script

Author: haileyajohnson

gradle/root/fatJars.gradle

@@ -30,7 +30,6 @@ configurations {
   ncIdv
   netcdfAll
   toolsUI
-  dap4lib
 }
 
 dependencies {
@@ -62,11 +61,6 @@ dependencies {
   toolsUI enforcedPlatform(project(':netcdf-java-platform'))
   toolsUI project(':uicdm')
   toolsUI 'ch.qos.logback:logback-classic'
-
-  dap4lib enforcedPlatform(project(':netcdf-java-platform'))
-  dap4lib project(':dap4:d4core')
-  dap4lib project(':dap4:d4lib')
-  dap4lib 'ch.qos.logback:logback-classic'
 }
 
 def fatJarTasks = []
@@ -110,17 +104,6 @@ fatJarTasks << tasks.create(name: 'buildToolsUI', type: ShadowJar) {
   }
 }
 
-fatJarTasks << tasks.create(name: 'buildDap4Lib', type: ShadowJar) {
-  archiveBaseName = 'dap4lib'
-  baseName = 'dap4lib'
-  setArchiveBaseName('dap4lib')
-  configurations = [project.configurations.dap4lib]
-
-  doFirst {
-    manifest.attributes project(':dap4:d4lib').tasks.jar.manifest.attributes
-  }
-}
-
 // Common configuration.
 configure(fatJarTasks) {
   dependsOn configurations*.buildDependencies
@@ -154,5 +137,4 @@ artifacts {
   archives buildNcIdv
   archives buildNetcdfAll
   archives buildToolsUI
-  archives buildDap4Lib
 }

gradle/root/publishing.gradle

@@ -82,7 +82,7 @@ def createChecksumsTask = tasks.register('createChecksums') {
       }
     }
   }
-  dependsOn buildDap4Lib, buildNcIdv, buildNetcdfAll, buildToolsUI
+  dependsOn buildNcIdv, buildNetcdfAll, buildToolsUI
 }
 
 def publishFatJarsTask = tasks.register('publishFatJars', PublishToRawRepoTask) {
@@ -105,3 +105,21 @@ def publishFatJarsTask = tasks.register('publishFatJars', PublishToRawRepoTask)
 }
 
 publish.dependsOn publishFatJarsTask
+
+// The "publish" tasks for all subprojects require credentials for our Nexus server, which they look for in Gradle
+// properties. If those properties (i.e. NEXUS_USERNAME_KEY and NEXUS_PASSWORD_KEY) haven't been provided, the build
+// will fail. Therefore, we only want to configure credentials when a "publish" task is part of the execution plan.
+// Otherwise, unavailable credentials could cause a build to fail even if we aren't doing any publishing. The
+// TaskExecutionGraph allows us to do that.
+gradle.taskGraph.whenReady {TaskExecutionGraph taskGraph ->
+  // This won't find any publishToMavenLocal tasks. Those are of type PublishToMavenLocal
+  Collection<Task> mavenPublishTasks = taskGraph.allTasks.findAll {
+    it instanceof PublishToMavenRepository
+  }
+  mavenPublishTasks.each {
+    it.repository.credentials.with {
+      username = getPropertyOrFailBuild NEXUS_USERNAME_KEY
+      password = getPropertyOrFailBuild NEXUS_PASSWORD_KEY
+    }
+  }
+ }