Skip to content

Commit e797b6b

Browse files
committed
Avoid unnecessarily exposing version and REQ_VERSION from GridDatasetInv
1 parent 85fb88b commit e797b6b

1 file changed

Lines changed: 9 additions & 28 deletions

File tree

cdm/core/src/main/java/ucar/nc2/ft/fmrc/GridDatasetInv.java

Lines changed: 9 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -65,16 +65,6 @@ public static GridDatasetInv open(MCollection cm, MFile mfile, Element ncml) thr
6565
}
6666
}
6767

68-
/**
69-
* Check if a given version of the GribDatasetInv xml format can be read by this code.
70-
*
71-
* @param version GridDatasetInv xml format version
72-
* @return true if version can be read, otherwise false.
73-
*/
74-
public static boolean isXmlVersionCompatible(int version) {
75-
return version >= REQ_VERSION;
76-
}
77-
7868
private static class GenerateInv implements Callable<GridDatasetInv> {
7969
private final MCollection cm;
8070
private final MFile mfile;
@@ -203,6 +193,15 @@ public String toString() {
203193
return location;
204194
}
205195

196+
/**
197+
* Check if the GribDatasetInv xml format can be fully understood by this code.
198+
*
199+
* @return true if version can be fully understood, otherwise false.
200+
*/
201+
public boolean isXmlVersionCompatible() {
202+
return this.version >= REQ_VERSION;
203+
}
204+
206205
public String getLocation() {
207206
return location;
208207
}
@@ -211,24 +210,6 @@ public long getLastModified() {
211210
return lastModified.getTime();
212211
}
213212

214-
/**
215-
* Version of the grid inventory format used by this inventory object
216-
*
217-
* @return grid inventory version
218-
*/
219-
public int getVersion() {
220-
return version;
221-
}
222-
223-
/**
224-
* Minimum support version of the GridDatasetInv inventory format that can be read.
225-
*
226-
* @return minimum supported version
227-
*/
228-
public static int getMinimumSupportedVersion() {
229-
return REQ_VERSION;
230-
}
231-
232213
/**
233214
* Get the date of the ForecastModelRun
234215
*

0 commit comments

Comments
 (0)