Avoid that the HDRPBuild data is never initialized if the Graphics Settings Provider is opened.

When building, the Graphics Settings provider was being launched as the asset was changed making the HDRPBuild data incorrect.

- Checking that the UI is not reloaded when building.
- Checking if the instance is already correct do not ensure it.
- Storing in the HDRPBuild data needed data for shader stripping.

Author: alex-vazquez-unity3d

Packages/com.unity.render-pipelines.core/Editor/BuildProcessors/CorePreprocessBuild.cs

@@ -6,7 +6,7 @@ namespace UnityEditor.Rendering
     //Make CoreBuildData constructed and kept till end of build
     class CorePreprocessBuild : IPreprocessBuildWithReport, IPostprocessBuildWithReport
     {
-        int IOrderedCallback.callbackOrder => -1;
+        int IOrderedCallback.callbackOrder => int.MinValue + 50;
 
         private static CoreBuildData m_BuildData = null;
 
@@ -22,4 +22,4 @@ void IPostprocessBuildWithReport.OnPostprocessBuild(BuildReport report)
             m_BuildData = null;
         }
     }
-}
+}

Packages/com.unity.render-pipelines.high-definition/Editor/BuildProcessors/HDRPBuildData.cs

@@ -19,6 +19,9 @@ internal class HDRPBuildData : IDisposable
         public Dictionary<int, ComputeShader> rayTracingComputeShaderCache { get; private set; } = new();
         public Dictionary<int, ComputeShader> computeShaderCache { get; private set; } = new();
 
+        public HDRenderPipelineRuntimeShaders runtimeShaders { get; private set; }
+        public HDRenderPipelineRuntimeMaterials materialResources { get; private set; }
+
         public HDRPBuildData()
         {
 
@@ -41,15 +44,20 @@ public HDRPBuildData(BuildTarget buildTarget, bool isDevelopmentBuild)
                     }
                 }
 
-                var hdrpGlobalSettingsInstance = HDRenderPipelineGlobalSettings.Ensure();
+                var hdrpGlobalSettingsInstance = HDRenderPipelineGlobalSettings.instance;
+                if (hdrpGlobalSettingsInstance == null)
+                    hdrpGlobalSettingsInstance = HDRenderPipelineGlobalSettings.Ensure();
+
                 if (hdrpGlobalSettingsInstance != null)
                 {
                     GraphicsSettings.GetRenderPipelineSettings<HDRPRayTracingResources>()
                         .ForEachFieldOfType<ComputeShader>(computeShader => rayTracingComputeShaderCache.Add(computeShader.GetInstanceID(), computeShader));
 
-                    var runtimeShaders = GraphicsSettings.GetRenderPipelineSettings<HDRenderPipelineRuntimeShaders>();
+                    runtimeShaders = GraphicsSettings.GetRenderPipelineSettings<HDRenderPipelineRuntimeShaders>();
                     runtimeShaders?.ForEachFieldOfType<ComputeShader>(computeShader => computeShaderCache.Add(computeShader.GetInstanceID(), computeShader));
 
+                    materialResources = GraphicsSettings.GetRenderPipelineSettings<HDRenderPipelineRuntimeMaterials>();
+
                     stripDebugVariants = !isDevelopmentBuild || GraphicsSettings.GetRenderPipelineSettings<ShaderStrippingSetting>().stripRuntimeDebugShaders;
                 }
             }
@@ -65,6 +73,8 @@ public void Dispose()
             playerNeedRaytracing = false;
             stripDebugVariants = true;
             buildingPlayerForHDRenderPipeline = false;
+            runtimeShaders = null;
+            materialResources = null;
             m_Instance = null;
         }
     }

Packages/com.unity.render-pipelines.high-definition/Editor/BuildProcessors/HDRPPreprocessBuild.cs

@@ -22,7 +22,7 @@ enum ShaderFeatures : long
 
     class HDRPPreprocessBuild : IPreprocessBuildWithReport, IPostprocessBuildWithReport
     {
-        public int callbackOrder => 0;
+        public int callbackOrder => int.MinValue + 100;
 
         private static HDRPBuildData m_BuildData = null;
         private static List<ShaderFeatures> s_SupportedFeaturesList = new();

Packages/com.unity.render-pipelines.high-definition/Editor/BuildProcessors/HDRPPreprocessShaders.cs

@@ -13,8 +13,8 @@ class CommonShaderPreprocessor : BaseShaderPreprocessor
 
         public CommonShaderPreprocessor()
         {
-            m_ShaderResources = GraphicsSettings.GetRenderPipelineSettings<HDRenderPipelineRuntimeShaders>();
-            m_MaterialResources = GraphicsSettings.GetRenderPipelineSettings<HDRenderPipelineRuntimeMaterials>();
+            m_ShaderResources = HDRPBuildData.instance.runtimeShaders;
+            m_MaterialResources = HDRPBuildData.instance.materialResources;
         }
 
         protected override bool DoShadersStripper(HDRenderPipelineAsset hdrpAsset, Shader shader, ShaderSnippetData snippet, ShaderCompilerData inputData)

Packages/com.unity.render-pipelines.high-definition/Editor/BuildProcessors/ShaderStrippers/HDRPComputeShaderVariantStripper.cs

@@ -20,7 +20,7 @@ class HDRPComputeShaderVariantStripper : IComputeShaderVariantStripper, ICompute
 
         public HDRPComputeShaderVariantStripper()
         {
-            m_Shaders = GraphicsSettings.GetRenderPipelineSettings<HDRenderPipelineRuntimeShaders>();
+            m_Shaders = HDRPBuildData.instance.runtimeShaders;
         }
 
         // Modify this function to add more stripping clauses

Packages/com.unity.render-pipelines.universal/Editor/BuildProcessors/URPPreprocessBuild.cs

@@ -11,7 +11,7 @@ namespace UnityEditor.Rendering.Universal
 {
     class URPPreprocessBuild : IPreprocessBuildWithReport
     {
-        public int callbackOrder => -1;
+        public int callbackOrder => int.MinValue + 100;
 
         private static URPBuildData m_BuildData = null;