fix: relogin when auth token is stale [MTT-3253] (#604)

* Added relogin functionality

It is triggered before any of the UI's do lobby api calls.

* AuthServiceFacade now has EnsurePlayerIsAuthorized that returns bools

lobby ui adjusted accrodingly, to handle the failures to re-authorize and to not do further calls if such failure occurs

Author: pdeschain

Assets/BossRoom/Scripts/Client/Game/State/ClientMainMenuState.cs

@@ -63,7 +63,7 @@ async void InjectDependenciesAndInitialize(AuthenticationServiceFacade authServi
                     unityAuthenticationInitOptions.SetProfile(profile);
                 }
 
-                await authServiceFacade.SignInAsync(unityAuthenticationInitOptions);
+                await authServiceFacade.InitializeAndSignInAsync(unityAuthenticationInitOptions);
                 OnAuthSignIn();
             }
             catch (Exception)

Assets/BossRoom/Scripts/Client/UI/Lobby/LobbyUIMediator.cs

@@ -1,4 +1,5 @@
 using System;
+using BossRoom.Scripts.Shared.Net.UnityServices.Auth;
 using TMPro;
 using Unity.Multiplayer.Samples.BossRoom.Client;
 using Unity.Multiplayer.Samples.BossRoom.Shared.Infrastructure;
@@ -21,6 +22,7 @@ public class LobbyUIMediator : MonoBehaviour
         [SerializeField] TextMeshProUGUI m_PlayerNameLabel;
         [SerializeField] GameObject m_LoadingSpinner;
 
+        AuthenticationServiceFacade m_AuthenticationServiceFacade;
         LobbyServiceFacade m_LobbyServiceFacade;
         LocalLobbyUser m_LocalUser;
         LocalLobby m_LocalLobby;
@@ -32,6 +34,7 @@ public class LobbyUIMediator : MonoBehaviour
 
         [Inject]
         void InjectDependenciesAndInitialize(
+            AuthenticationServiceFacade authenticationServiceFacade,
             LobbyServiceFacade lobbyServiceFacade,
             LocalLobbyUser localUser,
             LocalLobby localLobby,
@@ -40,6 +43,7 @@ void InjectDependenciesAndInitialize(
             ClientGameNetPortal clientGameNetPortal
         )
         {
+            m_AuthenticationServiceFacade = authenticationServiceFacade;
             m_NameGenerationData = nameGenerationData;
             m_LocalUser = localUser;
             m_LobbyServiceFacade = lobbyServiceFacade;
@@ -72,6 +76,14 @@ public async void CreateLobbyRequest(string lobbyName, bool isPrivate, int maxPl
 
             BlockUIWhileLoadingIsInProgress();
 
+            bool playerIsAuthorized = await m_AuthenticationServiceFacade.EnsurePlayerIsAuthorized();
+
+            if (!playerIsAuthorized)
+            {
+                UnblockUIAfterLoadingIsComplete();
+                return;
+            }
+
             var lobbyCreationAttempt = await m_LobbyServiceFacade.TryCreateLobbyAsync(lobbyName, maxPlayers, isPrivate);
 
             if (lobbyCreationAttempt.Success)
@@ -102,6 +114,14 @@ public async void QueryLobbiesRequest(bool blockUI)
                 BlockUIWhileLoadingIsInProgress();
             }
 
+            bool playerIsAuthorized = await m_AuthenticationServiceFacade.EnsurePlayerIsAuthorized();
+
+            if (!playerIsAuthorized)
+            {
+                UnblockUIAfterLoadingIsComplete();
+                return;
+            }
+
             await m_LobbyServiceFacade.RetrieveAndPublishLobbyListAsync();
             UnblockUIAfterLoadingIsComplete();
         }
@@ -110,6 +130,14 @@ public async void JoinLobbyWithCodeRequest(string lobbyCode)
         {
             BlockUIWhileLoadingIsInProgress();
 
+            bool playerIsAuthorized = await m_AuthenticationServiceFacade.EnsurePlayerIsAuthorized();
+
+            if (!playerIsAuthorized)
+            {
+                UnblockUIAfterLoadingIsComplete();
+                return;
+            }
+
             var result = await m_LobbyServiceFacade.TryJoinLobbyAsync(null, lobbyCode);
 
             if (result.Success)
@@ -126,6 +154,14 @@ public async void JoinLobbyRequest(LocalLobby lobby)
         {
             BlockUIWhileLoadingIsInProgress();
 
+            bool playerIsAuthorized = await m_AuthenticationServiceFacade.EnsurePlayerIsAuthorized();
+
+            if (!playerIsAuthorized)
+            {
+                UnblockUIAfterLoadingIsComplete();
+                return;
+            }
+
             var result = await m_LobbyServiceFacade.TryJoinLobbyAsync(lobby.LobbyID, lobby.LobbyCode);
 
             if (result.Success)
@@ -142,6 +178,14 @@ public async void QuickJoinRequest()
         {
             BlockUIWhileLoadingIsInProgress();
 
+            bool playerIsAuthorized = await m_AuthenticationServiceFacade.EnsurePlayerIsAuthorized();
+
+            if (!playerIsAuthorized)
+            {
+                UnblockUIAfterLoadingIsComplete();
+                return;
+            }
+
             var result = await m_LobbyServiceFacade.TryQuickJoinLobbyAsync();
 
             if (result.Success)

Assets/BossRoom/Scripts/Shared/Net/UnityServices/Auth/AuthenticationServiceFacade.cs

@@ -18,7 +18,7 @@ void InjectDependencies(IPublisher<UnityServiceErrorMessage> unityServiceErrorMe
             m_UnityServiceErrorMessagePublisher = unityServiceErrorMessagePublisher;
         }
 
-        public async Task SignInAsync(InitializationOptions initializationOptions)
+        public async Task InitializeAndSignInAsync(InitializationOptions initializationOptions)
         {
             try
             {
@@ -35,8 +35,35 @@ public async Task SignInAsync(InitializationOptions initializationOptions)
                 m_UnityServiceErrorMessagePublisher.Publish(new UnityServiceErrorMessage("Authentication Error", reason, UnityServiceErrorMessage.Service.Authentication, e));
                 throw;
             }
+        }
 
+        public async Task<bool> EnsurePlayerIsAuthorized()
+        {
+            if (AuthenticationService.Instance.IsAuthorized)
+            {
+                return true;
+            }
 
+            try
+            {
+                await AuthenticationService.Instance.SignInAnonymouslyAsync();
+                return true;
+            }
+            catch (AuthenticationException e)
+            {
+                var reason = $"{e.Message} ({e.InnerException?.Message})";
+                m_UnityServiceErrorMessagePublisher.Publish(new UnityServiceErrorMessage("Authentication Error", reason, UnityServiceErrorMessage.Service.Authentication, e));
+                //not rethrowing for authentication exceptions - any failure to authenticate is considered "handled failure"
+                return false;
+            }
+            catch (Exception e)
+            {
+                //all other exceptions should still bubble up as unhandled ones
+                var reason = $"{e.Message} ({e.InnerException?.Message})";
+                m_UnityServiceErrorMessagePublisher.Publish(new UnityServiceErrorMessage("Authentication Error", reason, UnityServiceErrorMessage.Service.Authentication, e));
+                throw;
+            }
         }
+
     }
 }