fix: mage heal fx plays out for whole duration & stays at spawn rotation [MTT-4476] (#771)

Author: fernando-cortez

Assets/Scripts/VisualEffects/SpecialFXGraphic.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
@@ -47,14 +48,22 @@ public class SpecialFXGraphic : MonoBehaviour
         [Tooltip("After Shutdown, how long before we self-destruct? 0 means no self destruct. -1 means self-destruct after ALL particles have disappeared")]
         private float m_PostShutdownSelfDestructTime = -1;
 
+        [SerializeField]
+        [Tooltip("If this graphic should keep its spawn rotation during its lifetime.")]
+        bool m_StayAtSpawnRotation;
+
         // track when Shutdown() is called so we don't try to do it twice
         private bool m_IsShutdown = false;
 
         // we keep a reference to our self-destruction coroutine in case we need to abort it prematurely
         private Coroutine coroWaitForSelfDestruct = null;
 
+        Quaternion m_StartRotation;
+
         private void Start()
         {
+            m_StartRotation = transform.rotation;
+
             if (m_AutoShutdownTime != -1)
             {
                 coroWaitForSelfDestruct = StartCoroutine(CoroWaitForSelfDestruct());
@@ -124,6 +133,13 @@ private IEnumerator CoroWaitForSelfDestruct()
             }
         }
 
+        void Update()
+        {
+            if (m_StayAtSpawnRotation)
+            {
+                transform.rotation = m_StartRotation;
+            }
+        }
     }
 
 

Assets/VFX/Prefabs/Shared Hero FX/FX_Buff.prefab

@@ -106,7 +106,7 @@ ParticleSystem:
       m_PreInfinity: 2
       m_PostInfinity: 2
       m_RotationOrder: 4
-  moveWithTransform: 1
+  moveWithTransform: 0
   moveWithCustomTransform: {fileID: 0}
   scalingMode: 1
   randomSeed: 5677
@@ -4925,11 +4925,15 @@ MonoBehaviour:
   m_Enabled: 1
   m_EditorHideFlags: 0
   m_Script: {fileID: 11500000, guid: 8e80714725b908940a76375b52b8d53b, type: 3}
-  m_Name: 
-  m_EditorClassIdentifier: 
-  m_ParticleSystemsToTurnOffOnShutdown: []
+  m_Name:
+  m_EditorClassIdentifier:
+  m_ParticleSystemsToTurnOffOnShutdown:
+  - {fileID: 5082887311387214394}
+  - {fileID: 5082887310581284565}
+  - {fileID: 5082887311598866503}
   m_AutoShutdownTime: 3
   m_PostShutdownSelfDestructTime: -1
+  m_StayAtSpawnRotation: 1
 --- !u!1 &5082887311387214391
 GameObject:
   m_ObjectHideFlags: 0
@@ -9915,7 +9919,7 @@ ParticleSystem:
       m_PreInfinity: 2
       m_PostInfinity: 2
       m_RotationOrder: 4
-  moveWithTransform: 1
+  moveWithTransform: 0
   moveWithCustomTransform: {fileID: 0}
   scalingMode: 1
   randomSeed: 5678

CHANGELOG.md

@@ -24,6 +24,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 * Reenabled depth buffer in the URP settings to enable the use of soft particles (#762)
 * Moved a torch out of a corner so that the flame VFX don't clip (#768)
 * Fixed issue where pressing 1 on keyboard would not invoke Revive or Pickup/Drop Actions (#770) Authority on modification of displayed Action now comes from a single spot, ClientInputSender.
+* Mage's heal FX plays out on itself and on targets. Added ability for SpecialFXGraphic components to remain at spawn rotation (#771)
 
 ## [2.0.0] - 2022-10-06