removed feature to set all players unready in char select when a player leaves or joins (#625)

Author: LPLafontaineB

Assets/BossRoom/Scripts/Server/Game/State/ServerCharSelectState.cs

@@ -135,26 +135,6 @@ void CancelCloseLobby()
                 StopCoroutine(m_WaitToEndLobbyCoroutine);
             }
             CharSelectData.IsLobbyClosed.Value = false;
-            // Set all players unready so they can react to this cancellation
-            SetAllUnready();
-        }
-
-        void SetAllUnready()
-        {
-            for (int i = 0; i < CharSelectData.LobbyPlayers.Count; ++i)
-            {
-                // Set all locked players to active so that they have to confirm their choice again
-                if (CharSelectData.LobbyPlayers[i].SeatState == CharSelectData.SeatState.LockedIn)
-                {
-                    CharSelectData.LobbyPlayers[i] = new CharSelectData.LobbyPlayerState(
-                        CharSelectData.LobbyPlayers[i].ClientId,
-                        CharSelectData.LobbyPlayers[i].PlayerName,
-                        CharSelectData.LobbyPlayers[i].PlayerNumber,
-                        CharSelectData.SeatState.Active,
-                        CharSelectData.LobbyPlayers[i].SeatIdx,
-                        CharSelectData.LobbyPlayers[i].LastChangeTime);
-                }
-            }
         }
 
         void SaveLobbyResults()
@@ -283,17 +263,10 @@ void OnClientDisconnectCallback(ulong clientId)
                 }
             }
 
-
-            if (CharSelectData.IsLobbyClosed.Value)
-            {
-                // If lobby is closing and waiting to start the game, cancel so that other players can react to it, and
-                // wait for the player coming back if they want to.
-                CancelCloseLobby();
-            }
-            else
+            if (!CharSelectData.IsLobbyClosed.Value)
             {
-                // If it is not closing, set everyone as unready for the same reason
-                SetAllUnready();
+                // If the lobby is not already closing, close if the remaining players are all ready
+                CloseLobbyIfReady();
             }
         }
     }