clean CI code a bit + add CodeQL steps (#13)

Author: ValentinFrancois

.github/workflows/_code_checks.yml

@@ -42,9 +42,15 @@ jobs:
         pip install -r requirements.txt
 
     - name: lint
-      run: |
-        make lint
+      run: make lint
 
     - name: test
-      run: |
-        make test
+      run: make test
+
+    - name: codeql_init
+      uses: github/codeql-action/init@v1
+      with:
+        languages: 'python'
+
+    - name: codeql_analyze
+      uses: github/codeql-action/analyze@v1

.github/workflows/release.yml

@@ -39,32 +39,28 @@ jobs:
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
-        pip install bump2version
+        pip install --upgrade -r requirements_release.txt
 
     - name: Bump Major Version
       env:
         COMMIT_MSG: ${{ github.event.head_commit.message }}
-      run: |
-        bump2version major
+      run: bump2version major
       if: startsWith(github.event.head_commit.message, '[MAJOR]')
 
     - name: Bump Minor Version
       env:
         COMMIT_MSG: ${{ github.event.head_commit.message }}
-      run: |
-        bump2version minor
+      run: bump2version minor
       if: startsWith(github.event.head_commit.message, '[MINOR]')
 
     - name: Bump Patch Version
       env:
         COMMIT_MSG: ${{ github.event.head_commit.message }}
-      run: |
-        bump2version patch
+      run: bump2version patch
       if: startsWith(github.event.head_commit.message, '[PATCH]')
 
     - name: Commit version change to main
-      run: |
-        git push --follow-tags
+      run: git push --follow-tags
 
   code_checks:
     needs: version_bump
@@ -117,12 +113,10 @@ jobs:
 
       - name: Build pypi package
         run: |
-          python3 -m pip install -U setuptools twine wheel
-          rm -rf dist
-          python3 setup.py sdist
-          python3 -m twine check dist/*
+          python -m pip install --upgrade pip
+          pip install --upgrade -r requirements_release.txt
+          make build_package
 
       - name: Publish pypi package
         run: |
-          ls -la
-          python3 -m twine upload --verbose -u __token__ -p ${{ secrets.PYPI_API_TOKEN }} dist/*
+          make publish_package TWINE_USERNAME=__token__ TWINE_PASSWORD=${{ secrets.PYPI_API_TOKEN }}

Makefile

@@ -9,3 +9,19 @@ test:
 	then python3 -m pytest tests; \
 	else nosetests -v --with-coverage --cover-package=$(PROJECT) tests; \
 	fi
+
+build_package:
+	rm -rf dist && \
+	python3 setup.py sdist && \
+	python3 -m twine check dist/*
+
+publish_package:
+ifndef TWINE_USERNAME
+	$(error TWINE_USERNAME is not set)
+else
+ifndef TWINE_PASSWORD
+	$(error TWINE_PASSWORD is not set)
+endif
+endif
+	python3 -m twine upload --verbose -u $(TWINE_USERNAME) -p $(TWINE_PASSWORD) dist/*
+

requirements_release.txt

@@ -0,0 +1,4 @@
+bump2version
+setuptools
+twine
+wheel