Skip to content

Commit d2eb78f

Browse files
author
Fergus Dixon
committed
update finding trace ID functionality, seems to result in some kind of deadlock though
1 parent 3d02d02 commit d2eb78f

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "ddtrace"
3-
version = "0.1.0"
3+
version = "0.1.1"
44
authors = ["David Steiner <david_j_steiner@yahoo.co.nz", "Fergus Strangways-Dixon <fergusdixon101@gmail.com>"]
55
edition = "2021"
66
license = "MIT"
@@ -27,5 +27,6 @@ serde_json = "^1.0.95"
2727
tokio = { version = "^1.26.0", features = ["signal"], optional = true }
2828
tracing = "^0.1.37"
2929
tracing-opentelemetry = "^0.19.0"
30+
tracing-opentelemetry-instrumentation-sdk = "^0.12.0"
3031
tracing-serde = "^0.1.3"
3132
tracing-subscriber = { version = "^0.3.16", features = ["env-filter", "json"] }

src/formatter.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,12 @@
88
use std::io;
99

1010
use chrono::Utc;
11-
use opentelemetry::trace::{SpanId, TraceContextExt, TraceId};
11+
use opentelemetry::trace::{SpanId, TraceId};
1212
use serde::ser::{SerializeMap, Serializer as _};
1313
use serde::Serialize;
1414
use tracing::{Event, Subscriber};
1515
use tracing_opentelemetry::OtelData;
16+
use tracing_opentelemetry_instrumentation_sdk::find_current_trace_id;
1617
use tracing_serde::fields::AsMap;
1718
use tracing_serde::AsSerde;
1819
use tracing_subscriber::fmt::format::Writer;
@@ -45,7 +46,10 @@ where
4546
S: Subscriber + for<'a> LookupSpan<'a>,
4647
{
4748
span_ref.extensions().get::<OtelData>().map(|o| TraceInfo {
48-
trace_id: o.parent_cx.span().span_context().trace_id().into(),
49+
trace_id: TraceId::from_hex(
50+
&*find_current_trace_id()
51+
.unwrap_or(TraceId::INVALID.to_string()))
52+
.unwrap_or(TraceId::INVALID).into(),
4953
span_id: o.builder.span_id.unwrap_or(SpanId::INVALID).into(),
5054
})
5155
}

0 commit comments

Comments
 (0)