Serialize kv2 byte arrays as "binary" at all times (asset_preview_thumbnail in map files)

kristiker · kristiker · commit d12405743f10 · 2024-01-21T21:06:33.000+01:00
diff --git a/Codecs/KeyValues2.cs b/Codecs/KeyValues2.cs
@@ -177,8 +177,14 @@ void WriteAttribute(string name, Type type, object value, bool in_array)
             {
                 // TODO: subclass check in this method like above - and in all other places with == typeof(Element)
                 inner_type = Datamodel.GetArrayInnerType(type);
+
+                if (inner_type == typeof(byte))
+                    inner_type = null; // serialize as binary at all times
+
+                /*
                 if (inner_type == typeof(byte) && !ValidAttributes[EncodingVersion].Contains(typeof(byte)))
                     inner_type = null; // fall back on the "binary" type in older KV2 versions
+                */
             }
 
             // Elements are supported by all.

Original file line number	Diff line number	Diff line change
`@@ -177,8 +177,14 @@ void WriteAttribute(string name, Type type, object value, bool in_array)`
`177`	`177`	`{`
`178`	`178`	`// TODO: subclass check in this method like above - and in all other places with == typeof(Element)`
`179`	`179`	`inner_type = Datamodel.GetArrayInnerType(type);`
	`180`	`+`
	`181`	`+ if (inner_type == typeof(byte))`
	`182`	`+ inner_type = null; // serialize as binary at all times`
	`183`	`+`
	`184`	`+ /*`
`180`	`185`	`if (inner_type == typeof(byte) && !ValidAttributes[EncodingVersion].Contains(typeof(byte)))`
`181`	`186`	`inner_type = null; // fall back on the "binary" type in older KV2 versions`
	`187`	`+ */`
`182`	`188`	`}`
`183`	`189`
`184`	`190`	`// Elements are supported by all.`