Fix spurious cross-reference updates during startup initialization. Save the polar bears.

Author: bpotchik

ui/viewframe.h

@@ -34,20 +34,22 @@ struct BINARYNINJAUIAPI SelectionInfoForXref
 	// At any given time, at most one of these four should be true.
 	bool addrValid, typeValid, typeFieldValid, localVarValid;
 
-	BNFunctionGraphType ilSource;
+	BNFunctionGraphType ilSource = InvalidILViewType;
 
-	uint64_t start;
-	uint64_t end;
+	uint64_t start = 0;
+	uint64_t end = 0;
 
 	BinaryNinja::QualifiedName type;
-	uint64_t offset;
+	uint64_t offset = 0;
 
 	BinaryNinja::Variable var;
 
 	// These two need to be tested against nullptr before de-referencing
 	FunctionRef func;
 	ArchitectureRef arch;
 
+	SelectionInfoForXref() : addrValid(false), typeValid(false), typeFieldValid(false), localVarValid(false) { }
+
 	bool operator==(const SelectionInfoForXref& other) const
 	{
 		if (addrValid && other.addrValid)

ui/xreflist.h

@@ -644,6 +644,7 @@ class BINARYNINJAUIAPI CrossReferenceWidget : public SidebarWidget, public UICon
 	bool m_navToNextOrPrevStarted = false;
 	bool m_pinned;
 	bool m_uiMaxItemsExceeded = false;
+	bool m_hasInitialSelection = false;
 
 	QWidget* m_header = nullptr;