Skip to content

Commit 8dd4e14

Browse files
committed
[SharedCache] Always initialize logger first
Potential nullptr deref on invalid view type (see the error log right after the logger init)
1 parent 95d84de commit 8dd4e14

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

view/sharedcache/core/SharedCache.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1363,6 +1363,7 @@ void SharedCache::ParseAndApplySlideInfoForFile(std::shared_ptr<MMappedFileAcces
13631363

13641364
SharedCache::SharedCache(BinaryNinja::Ref<BinaryNinja::BinaryView> dscView) : m_dscView(dscView), m_viewSpecificState(ViewSpecificStateForView(dscView))
13651365
{
1366+
m_logger = LogRegistry::GetLogger("SharedCache", dscView->GetFile()->GetSessionId());
13661367
if (dscView->GetTypeName() != VIEW_NAME)
13671368
{
13681369
// Unreachable?
@@ -1371,7 +1372,6 @@ SharedCache::SharedCache(BinaryNinja::Ref<BinaryNinja::BinaryView> dscView) : m_
13711372
}
13721373
sharedCacheReferences++;
13731374
INIT_SHAREDCACHE_API_OBJECT()
1374-
m_logger = LogRegistry::GetLogger("SharedCache", dscView->GetFile()->GetSessionId());
13751375
DeserializeFromRawView();
13761376
if (!m_metadataValid)
13771377
return;

0 commit comments

Comments
 (0)