Skip to content

Commit 44f66a3

Browse files
committed
- Removed resolved TODO annotations.
1 parent 9f9137c commit 44f66a3

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

vcert/common.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,13 @@ class ScopeAction(Enum):
6767
# Configuration Management scope
6868
_SCOPE_CFG = f"{Scope.CONFIGURATION.value}:{ScopeAction.MANAGE.value}"
6969
# Certificate Management scope
70-
SCOPE_CM = f"{Scope.CERTIFICATE.value}:{ScopeAction.MANAGE.value},{ScopeAction.REVOKE.value}" # TODO: REMOVE 'certificate:manage,revoke' # type: str
70+
SCOPE_CM = f"{Scope.CERTIFICATE.value}:{ScopeAction.MANAGE.value},{ScopeAction.REVOKE.value}"
7171
# Policy Management scope
72-
SCOPE_PM = f"{Scope.CERTIFICATE.value}:{ScopeAction.MANAGE.value};{_SCOPE_CFG}" # TODO: REMOVE 'certificate:manage;configuration:manage' # type: str
72+
SCOPE_PM = f"{Scope.CERTIFICATE.value}:{ScopeAction.MANAGE.value};{_SCOPE_CFG}"
7373
# SSH Certificate Management scope
74-
SCOPE_SSH = f"{Scope.SSH.value}:{ScopeAction.MANAGE.value}" # TODO: REMOVE 'ssh:manage' # type: str
74+
SCOPE_SSH = f"{Scope.SSH.value}:{ScopeAction.MANAGE.value}"
7575
# Full Management scope
76-
SCOPE_FULL = f"{SCOPE_CM};{_SCOPE_CFG};{SCOPE_SSH}" # TODO: REMOVE 'certificate:manage,revoke;configuration:manage;ssh:manage' # type: str
76+
SCOPE_FULL = f"{SCOPE_CM};{_SCOPE_CFG};{SCOPE_SSH}"
7777

7878

7979
class CertField:

vcert/pem.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def full_chain(self):
8282
if not self.chain:
8383
return self.cert
8484
full_chain = "\n".join(self.chain)
85-
return f"{self.cert}\n{full_chain}" # TODO: REMOVE self.cert + "\n" + "\n".join(self.chain)
85+
return f"{self.cert}\n{full_chain}"
8686

8787
def as_pkcs12(self, passphrase=None):
8888
"""

vcert/ssh_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
from .errors import ClientBadData, ServerUnexptedBehavior
2424

2525
PATH_SEPARATOR = "\\"
26-
CA_ROOT_PATH = f"{PATH_SEPARATOR}VED{PATH_SEPARATOR}Certificate Authority{PATH_SEPARATOR}SSH{PATH_SEPARATOR}Templates" # TODO: REMOVE PATH_SEPARATOR + "VED" + PATH_SEPARATOR + "Certificate Authority" + PATH_SEPARATOR + "SSH" + PATH_SEPARATOR + "Templates"
26+
CA_ROOT_PATH = f"{PATH_SEPARATOR}VED{PATH_SEPARATOR}Certificate Authority{PATH_SEPARATOR}SSH{PATH_SEPARATOR}Templates"
2727
DEFAULT_SSH_KEY_SIZE = 3072
2828
F_P_DETAILS = 'ProcessingDetails'
2929

@@ -84,7 +84,7 @@ def get_public_key_data(self):
8484
return None
8585
temp = self._public_key_data.rstrip("\r\n")
8686
if self.key_id:
87-
return f"{temp} {self.key_id}" # TODO: REMOVE "%s %s" % (temp, self.key_id)
87+
return f"{temp} {self.key_id}"
8888
else:
8989
return temp
9090

0 commit comments

Comments
 (0)