Skip to content

Commit 0eab423

Browse files
committed
remove redundant datetime in async callback
1 parent 93e2a06 commit 0eab423

3 files changed

Lines changed: 9 additions & 10 deletions

File tree

src/DiffEngineTray.Tests/AsyncTimerTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ public async Task It_calls_error_callback()
66
var errorCallbackInvoked = new TaskCompletionSource<bool>();
77

88
var timer = new AsyncTimer(
9-
callback: (_, _) => throw new("Simulated!"),
9+
callback: _ => throw new("Simulated!"),
1010
interval: TimeSpan.Zero,
1111
errorCallback: _ =>
1212
{
@@ -24,7 +24,7 @@ public async Task It_continues_to_run_after_an_error()
2424
var fail = true;
2525
var exceptionThrown = false;
2626
var timer = new AsyncTimer(
27-
callback: (_, _) =>
27+
callback: _ =>
2828
{
2929
if (fail)
3030
{
@@ -51,7 +51,7 @@ public async Task Stop_cancels_token_while_waiting()
5151
var waitCanceled = false;
5252
var delayStarted = new TaskCompletionSource<bool>();
5353
var timer = new AsyncTimer(
54-
callback: (_, _) => throw new("Simulated!"),
54+
callback: _ => throw new("Simulated!"),
5555
interval: TimeSpan.FromDays(7),
5656
delayStrategy: async (delayTime, token) =>
5757
{
@@ -79,7 +79,7 @@ public async Task Stop_cancels_token_while_in_callback()
7979
var callbackStarted = new TaskCompletionSource<bool>();
8080
var stopInitiated = new TaskCompletionSource<bool>();
8181
var timer = new AsyncTimer(
82-
callback: async (_, token) =>
82+
callback: async token =>
8383
{
8484
callbackStarted.SetResult(true);
8585
await stopInitiated.Task;
@@ -103,7 +103,7 @@ public async Task Stop_waits_for_callback_to_complete()
103103
var callbackCompleted = new TaskCompletionSource<bool>();
104104
var callbackTaskStarted = new TaskCompletionSource<bool>();
105105
var timer = new AsyncTimer(
106-
callback: (_, _) =>
106+
callback: _ =>
107107
{
108108
callbackTaskStarted.SetResult(true);
109109
return callbackCompleted.Task;

src/DiffEngineTray/AsyncTimer.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
class AsyncTimer :
22
IAsyncDisposable
33
{
4-
Func<DateTime, CancellationToken, Task> callback;
4+
Func<CancellationToken, Task> callback;
55
TimeSpan interval;
66
Action<Exception> errorCallback;
77
Func<TimeSpan, CancellationToken, Task> delayStrategy;
88
Task task;
99
CancellationTokenSource tokenSource = new();
1010

1111
public AsyncTimer(
12-
Func<DateTime, CancellationToken, Task> callback,
12+
Func<CancellationToken, Task> callback,
1313
TimeSpan interval,
1414
Action<Exception>? errorCallback = null,
1515
Func<TimeSpan, CancellationToken, Task>? delayStrategy = null)
@@ -36,9 +36,8 @@ async Task RunLoop(CancellationToken cancellation)
3636
{
3737
try
3838
{
39-
var utcNow = DateTime.UtcNow;
4039
await delayStrategy(interval, cancellation);
41-
await callback(utcNow, cancellation);
40+
await callback(cancellation);
4241
}
4342
catch (OperationCanceledException)
4443
{

src/DiffEngineTray/Tracker.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public Tracker(Action active, Action inactive)
2121
});
2222
}
2323

24-
Task ScanFiles(DateTime dateTime, CancellationToken cancellationToken)
24+
Task ScanFiles(CancellationToken cancellationToken)
2525
{
2626
foreach (var delete in deletes.ToList()
2727
.Where(delete => !File.Exists(delete.Value.File)))

0 commit comments

Comments
 (0)