Skip to content

Commit 381315d

Browse files
authored
Merge branch 'main' into feature/enable-aggr-vcs
2 parents b31dd94 + a16347d commit 381315d

5 files changed

Lines changed: 19 additions & 5 deletions

File tree

Endorser.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ Endorsement:
5656
For Authors, specify whether to automatically create transactions for a cred def's revocation registry. (If not specified, the controller must invoke the endpoints required to create
5757
the revocation registry and assign to the cred def.) [env var: ACAPY_CREATE_REVOCATION_TRANSACTIONS]
5858
--auto-promote-author-did
59-
For Authors, specify whether to automatically promote a DID to the wallet public DID after writing to the ledger.
59+
For Authors, specify whether to automatically promote a DID to the wallet public DID after writing to the ledger. [env var: ACAPY_AUTO_PROMOTE_AUTHOR_DID]
6060
```
6161

6262
## How Aca-py Handles Endorsements

aries_cloudagent/config/argparse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1837,7 +1837,7 @@ def add_arguments(self, parser: ArgumentParser):
18371837
parser.add_argument(
18381838
"--auto-promote-author-did",
18391839
action="store_true",
1840-
env_var="ACAPY_PROMOTE-AUTHOR-DID",
1840+
env_var="ACAPY_AUTO_PROMOTE_AUTHOR_DID",
18411841
help="For Authors, specify whether to automatically promote"
18421842
" a DID to the wallet public DID after writing to the ledger.",
18431843
)

aries_cloudagent/protocols/out_of_band/v1_0/manager.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ async def create_invitation(
121121
mediation_id,
122122
or_default=True,
123123
)
124+
image_url = self.profile.context.settings.get("image_url")
124125

125126
if not (hs_protos or attachments):
126127
raise OutOfBandManagerError(
@@ -235,6 +236,7 @@ async def create_invitation(
235236
services=[f"did:sov:{public_did.did}"],
236237
accept=service_accept if protocol_version != "1.0" else None,
237238
version=protocol_version or DEFAULT_VERSION,
239+
image_url=image_url,
238240
)
239241

240242
our_recipient_key = public_did.verkey
@@ -333,6 +335,7 @@ async def create_invitation(
333335
invi_msg.handshake_protocols = handshake_protocols
334336
invi_msg.requests_attach = message_attachments
335337
invi_msg.accept = service_accept if protocol_version != "1.0" else None
338+
invi_msg.image_url = image_url
336339
invi_msg.services = [
337340
ServiceMessage(
338341
_id="#inline",

aries_cloudagent/protocols/out_of_band/v1_0/messages/invitation.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ def __init__(
120120
*,
121121
comment: str = None,
122122
label: str = None,
123+
image_url: str = None,
123124
handshake_protocols: Sequence[Text] = None,
124125
requests_attach: Sequence[AttachDecorator] = None,
125126
services: Sequence[Union[Service, Text]] = None,
@@ -138,6 +139,7 @@ def __init__(
138139
# super().__init__(_id=_id, **kwargs)
139140
super().__init__(_type=msg_type, _version=version, **kwargs)
140141
self.label = label
142+
self.image_url = image_url
141143
self.handshake_protocols = (
142144
list(handshake_protocols) if handshake_protocols else []
143145
)
@@ -208,6 +210,13 @@ class Meta:
208210
example="https://didcomm.org/my-family/1.0/my-message-type",
209211
)
210212
label = fields.Str(required=False, description="Optional label", example="Bob")
213+
image_url = fields.URL(
214+
data_key="imageUrl",
215+
required=False,
216+
allow_none=True,
217+
description="Optional image URL for out-of-band invitation",
218+
example="http://192.168.56.101/img/logo.jpg",
219+
)
211220
handshake_protocols = fields.List(
212221
fields.Str(
213222
description="Handshake protocol",

demo/run_demo

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,10 @@ if [ -z "$DOCKER_NET" ]; then
2121
fi
2222
DOCKER_VOL=""
2323

24+
j=1
2425
for i in "$@"
2526
do
27+
((j++))
2628
if [ ! -z "$SKIP" ]; then
2729
SKIP=""
2830
continue
@@ -65,12 +67,12 @@ do
6567
continue
6668
;;
6769
--debug-pycharm-controller-port)
68-
PYDEVD_PYCHARM_CONTROLLER_PORT=$2
70+
PYDEVD_PYCHARM_CONTROLLER_PORT=${!j}
6971
SKIP=1
7072
continue
7173
;;
7274
--debug-pycharm-agent-port)
73-
PYDEVD_PYCHARM_AGENT_PORT=$2
75+
PYDEVD_PYCHARM_AGENT_PORT=${!j}
7476
SKIP=1
7577
continue
7678
;;
@@ -154,7 +156,7 @@ if [ ! -z "$DOCKERHOST" ]; then
154156
export RUNMODE="docker"
155157
elif [ -z "${PWD_HOST_FQDN}" ]; then
156158
# getDockerHost; for details refer to https://github.com/bcgov/DITP-DevOps/tree/main/code/snippets#getdockerhost
157-
. /dev/stdin <<<"$(cat <(curl -s --raw https://raw.githubusercontent.com/bcgov/DITP-DevOps/main/code/snippets/getDockerHost))"
159+
. /dev/stdin <<<"$(cat <(curl -s --raw https://raw.githubusercontent.com/bcgov/DITP-DevOps/main/code/snippets/getDockerHost))"
158160
export DOCKERHOST=$(getDockerHost)
159161
export RUNMODE="docker"
160162
else

0 commit comments

Comments
 (0)