Skip to content

Commit e806bde

Browse files
authored
Merge branch 'main' into filter-reg-created
2 parents 2fbcecf + 4e5ed0f commit e806bde

3 files changed

Lines changed: 12 additions & 2 deletions

File tree

aries_cloudagent/holder/routes.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,8 @@ async def credentials_remove(request: web.BaseRequest):
274274
async with context.profile.session() as session:
275275
holder = session.inject(IndyHolder)
276276
await holder.delete_credential(credential_id)
277+
topic = "acapy::record::credential::delete"
278+
await context.profile.notify(topic, {"id": credential_id, "state": "deleted"})
277279
except WalletNotFoundError as err:
278280
raise web.HTTPNotFound(reason=err.roll_up) from err
279281

@@ -376,6 +378,10 @@ async def w3c_cred_remove(request: web.BaseRequest):
376378
try:
377379
vc_record = await holder.retrieve_credential_by_id(credential_id)
378380
await holder.delete_credential(vc_record)
381+
topic = "acapy::record::w3c_credential::delete"
382+
await session.profile.notify(
383+
topic, {"id": credential_id, "state": "deleted"}
384+
)
379385
except StorageNotFoundError as err:
380386
raise web.HTTPNotFound(reason=err.roll_up) from err
381387
except StorageError as err:

aries_cloudagent/messaging/models/base_record.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,8 +418,11 @@ async def delete_record(self, session: ProfileSession):
418418

419419
if self._id:
420420
storage = session.inject(BaseStorage)
421+
if self.state:
422+
self._previous_state = self.state
423+
self.state = "deleted"
424+
await self.emit_event(session, self.serialize())
421425
await storage.delete_record(self.storage_record)
422-
# FIXME - update state and send webhook?
423426

424427
async def emit_event(self, session: ProfileSession, payload: Any = None):
425428
"""

aries_cloudagent/protocols/out_of_band/v1_0/tests/test_manager.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1321,7 +1321,8 @@ async def test_receive_invitation_connection_protocol(self):
13211321
]
13221322
assert not invitation.routing_keys
13231323

1324-
assert oob_record.state == OobRecord.STATE_DONE
1324+
assert oob_record.state == "deleted"
1325+
assert oob_record._previous_state == OobRecord.STATE_DONE
13251326

13261327
async def test_receive_invitation_services_with_neither_service_blocks_nor_dids(
13271328
self,

0 commit comments

Comments
 (0)