A couple of unit tests

Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>

Author: ianco

aries_cloudagent/ledger/tests/test_routes.py

@@ -359,6 +359,50 @@ async def test_register_nym_create_transaction_for_endorser(self):
                 {"success": True, "txn": {"signed_txn": {"...": "..."}}}
             )
 
+    async def test_register_nym_create_transaction_for_endorser_no_public_did(self):
+        self.request.query = {
+            "did": "a_test_did",
+            "verkey": "a_test_verkey",
+            "alias": "did_alias",
+            "role": "reset",
+            "create_transaction_for_endorser": "true",
+            "conn_id": "dummy",
+        }
+        self.profile.context.settings["endorser.author"] = True
+
+        with async_mock.patch.object(
+            ConnRecord, "retrieve_by_id", async_mock.AsyncMock()
+        ) as mock_conn_rec_retrieve, async_mock.patch.object(
+            test_module, "TransactionManager", async_mock.MagicMock()
+        ) as mock_txn_mgr, async_mock.patch.object(
+            test_module.web, "json_response", async_mock.MagicMock()
+        ) as mock_response:
+            mock_txn_mgr.return_value = async_mock.MagicMock(
+                create_record=async_mock.AsyncMock(
+                    return_value=async_mock.MagicMock(
+                        serialize=async_mock.MagicMock(return_value={"...": "..."})
+                    )
+                )
+            )
+            mock_conn_rec_retrieve.return_value = async_mock.MagicMock(
+                metadata_get=async_mock.AsyncMock(
+                    return_value={
+                        "endorser_did": ("did"),
+                        "endorser_name": ("name"),
+                    }
+                )
+            )
+            self.ledger.register_nym.return_value: Tuple[bool, dict] = (
+                True,
+                {"signed_txn": {"...": "..."}},
+            )
+
+            result = await test_module.register_ledger_nym(self.request)
+            assert result == mock_response.return_value
+            mock_response.assert_called_once_with(
+                {"success": True, "txn": {"signed_txn": {"...": "..."}}}
+            )
+
     async def test_register_nym_create_transaction_for_endorser_storage_x(self):
         self.request.query = {
             "did": "a_test_did",

aries_cloudagent/protocols/endorse_transaction/v1_0/tests/test_manager.py

@@ -115,6 +115,7 @@ async def setUp(self):
         self.ledger.txn_endorse = async_mock.CoroutineMock(
             return_value=self.test_endorsed_message
         )
+        self.ledger.register_nym = async_mock.CoroutineMock(return_value=(True, {}))
 
         self.context = AdminRequestContext.test_context()
         self.profile = self.context.profile
@@ -235,6 +236,48 @@ async def test_create_request(self):
             transaction_request.messages_attach == transaction_record.messages_attach[0]
         )
 
+    async def test_create_request_author_did(self):
+        transaction_record = await self.manager.create_record(
+            messages_attach=self.test_messages_attach,
+            connection_id=self.test_connection_id,
+        )
+
+        with async_mock.patch.object(
+            TransactionRecord, "save", autospec=True
+        ) as save_record:
+            (
+                transaction_record,
+                transaction_request,
+            ) = await self.manager.create_request(
+                transaction_record,
+                expires_time=self.test_expires_time,
+                author_goal_code=TransactionRecord.REGISTER_PUBLIC_DID,
+                signer_goal_code=TransactionRecord.WRITE_DID_TRANSACTION,
+            )
+            save_record.assert_called_once()
+
+        assert transaction_record._type == TransactionRecord.SIGNATURE_REQUEST
+        assert transaction_record.signature_request[0] == {
+            "context": TransactionRecord.SIGNATURE_CONTEXT,
+            "method": TransactionRecord.ADD_SIGNATURE,
+            "signature_type": TransactionRecord.SIGNATURE_TYPE,
+            "signer_goal_code": TransactionRecord.WRITE_DID_TRANSACTION,
+            "author_goal_code": TransactionRecord.REGISTER_PUBLIC_DID,
+        }
+        assert transaction_record.state == TransactionRecord.STATE_REQUEST_SENT
+        assert transaction_record.connection_id == self.test_connection_id
+        assert transaction_record.timing["expires_time"] == self.test_expires_time
+
+        assert transaction_request.transaction_id == transaction_record._id
+        assert (
+            transaction_request.signature_request
+            == transaction_record.signature_request[0]
+        )
+        assert transaction_request.timing == transaction_record.timing
+        assert (
+            transaction_request.messages_attach == transaction_record.messages_attach[0]
+        )
+
     async def test_recieve_request(self):
         mock_request = async_mock.MagicMock()
         mock_request.transaction_id = self.test_author_transaction_id
@@ -340,6 +383,55 @@ async def test_create_endorse_response(self):
         )
         assert endorsed_transaction_response.endorser_did == self.test_endorser_did
 
+    async def test_create_endorse_response_author_did(self):
+        transaction_record = await self.manager.create_record(
+            messages_attach=self.test_messages_attach,
+            connection_id=self.test_connection_id,
+        )
+
+        with async_mock.patch.object(
+            TransactionRecord, "save", autospec=True
+        ) as save_record:
+            (
+                transaction_record,
+                transaction_request,
+            ) = await self.manager.create_request(
+                transaction_record,
+                expires_time=self.test_expires_time,
+                author_goal_code=TransactionRecord.REGISTER_PUBLIC_DID,
+                signer_goal_code=TransactionRecord.WRITE_DID_TRANSACTION,
+            )
+            save_record.assert_called_once()
+
+        transaction_record.state = TransactionRecord.STATE_REQUEST_RECEIVED
+        transaction_record.thread_id = self.test_author_transaction_id
+        transaction_record.messages_attach[0]["data"]["json"] = json.dumps(
+            {
+                "did": "test",
+                "verkey": "test",
+                "alias": "test",
+                "role": "",
+            }
+        )
+
+        with async_mock.patch.object(
+            TransactionRecord, "save", autospec=True
+        ) as save_record:
+            (
+                transaction_record,
+                endorsed_transaction_response,
+            ) = await self.manager.create_endorse_response(
+                transaction_record,
+                state=TransactionRecord.STATE_TRANSACTION_ENDORSED,
+            )
+            save_record.assert_called_once()
+
+        assert transaction_record._type == TransactionRecord.SIGNATURE_RESPONSE
+        assert (
+            transaction_record.messages_attach[0]["data"]["json"]
+            == '{"result": {"txn": {"type": "1", "data": {"dest": "test"}}}, "meta_data": {"did": "test", "verkey": "test", "alias": "test", "role": ""}}'
+        )
+
     async def test_receive_endorse_response(self):
         transaction_record = await self.manager.create_record(
             messages_attach=self.test_messages_attach,