[wasm-dis] Enable all features for printing (#7802)

This enables all features for wasm-dis for printing.

wasm-dis currently enables all features at parsing time and restores the
originally enabled features at printing time, but doesn't do any
validation, so there's no point restoring the original features:

https://github.com/WebAssembly/binaryen/blob/e81f964d9cc70c71c4339e6558f57ebe8eb5cc32/src/tools/wasm-dis.cpp#L70-L73
https://github.com/WebAssembly/binaryen/blob/e81f964d9cc70c71c4339e6558f57ebe8eb5cc32/src/tools/wasm-dis.cpp#L94-L100
And even if we do validation, I'm not sure how many people would use
wasm-dis for validation anyway.

And it's easy to be misused. For example, running `wasm-dis` without any
options on a binary that has reference types enabled and has multiple
tables will not print any indices for `call_indirect`s and does not even
error out, happily producing a wast file that has incorrect semantics,
because without table references they will all mean whatever table at
index 0.

https://github.com/WebAssembly/binaryen/blob/21464e7533ef235634c8d62442a8a10cafff6568/src/passes/Print.cpp#L506-L509
Note that without `-all` you can even disassemble GC binaries with
`struct`s, because there's no validation. But we still don't print table
references for `call_indirect`s.

This PR removes that restoring and validation and enables all features
at all times for wasm-dis.

The test changes are two kinds:
- We now have a table reference for all `call_indirect`s
- We now have a type index for all `func`s

At least the first change is not compatible with MVP. (Not sure about
the second one.) But our wast parser doesn't seem to have any problems
with parsing these without `-all` of `--enable-reference-types` at the
moment.

Companion change:
emscripten-core/emscripten#24876

Author: aheejin

src/tools/wasm-dis.cpp

@@ -67,9 +67,6 @@ int main(int argc, const char* argv[]) {
   }
   Module wasm;
   options.applyOptionsBeforeParse(wasm);
-  // Temporarily apply all features during parsing to avoid any errors. See note
-  // below on skipping validation.
-  auto enabledFeatures = wasm.features;
   wasm.features = FeatureSet::All;
 
   try {
@@ -91,13 +88,6 @@ int main(int argc, const char* argv[]) {
 
   options.applyOptionsAfterParse(wasm);
 
-  // TODO: Validation. However, validating would mean that users are forced to
-  //       run with  wasm-dis -all  or such, to enable the features (unless the
-  //       features section is present, but that's rare in general). It would be
-  //       better to have an "autodetect" code path that enables used features
-  //       eventually.
-
-  wasm.features = enabledFeatures;
   if (options.debug) {
     std::cerr << "Printing..." << std::endl;
   }

test/br_to_exit.wasm.fromBinary

@@ -1,6 +1,6 @@
 (module
  (type $0 (func))
- (func $0
+ (func $0 (type $0)
   (block $label
    (br $label)
   )

test/br_to_try.wasm.fromBinary

@@ -2,7 +2,7 @@
  (type $0 (func (param i32)))
  (type $1 (func))
  (tag $tag$0 (type $0) (param i32))
- (func $0
+ (func $0 (type $1)
   (block $label
    (try
     (do

test/break-to-return.wasm.fromBinary

@@ -2,7 +2,7 @@
  (type $0 (func (param i32 i32) (result i32)))
  (memory $0 256 256)
  (export "add" (func $0))
- (func $0 (param $0 i32) (param $1 i32) (result i32)
+ (func $0 (type $0) (param $0 i32) (param $1 i32) (result i32)
   (block $label (result i32)
    (br $label
     (i32.add

test/break-within-catch.wasm.fromBinary

@@ -2,7 +2,7 @@
  (type $0 (func (param i32)))
  (type $1 (func))
  (tag $tag$0 (type $0) (param i32))
- (func $0
+ (func $0 (type $1)
   (block $label
    (try
     (do

test/complexBinaryNames.wasm.fromBinary

@@ -1,10 +1,10 @@
 (module
  (type $0 (func))
  (export "$zoo (.bar)" (func $1))
- (func $foo\20\28.bar\29
+ (func $foo\20\28.bar\29 (type $0)
   (nop)
  )
- (func $1
+ (func $1 (type $0)
   (call $foo\20\28.bar\29)
  )
 )

test/consume-stacky.wasm.fromBinary

@@ -1,7 +1,7 @@
 (module
  (type $0 (func (result i32)))
  (memory $0 1 1)
- (func $0 (result i32)
+ (func $0 (type $0) (result i32)
   (local $scratch i32)
   (local.set $scratch
    (i32.const 1)

test/dylib.wasm.fromBinary

@@ -5,10 +5,10 @@
  (type $3 (func (param i32 i32) (result i32)))
  (import "env" "memory" (memory $mimport$0 0))
  (import "env" "__memory_base" (global $gimport$0 i32))
- (import "env" "g$waka_mine" (func $fimport$0 (result i32)))
- (import "env" "g$waka_others" (func $fimport$1 (result i32)))
- (import "env" "fp$_Z16waka_func_theirsi$ii" (func $fimport$2 (result i32)))
- (import "env" "fp$_Z14waka_func_minei$ii" (func $fimport$3 (result i32)))
+ (import "env" "g$waka_mine" (func $fimport$0 (type $0) (result i32)))
+ (import "env" "g$waka_others" (func $fimport$1 (type $0) (result i32)))
+ (import "env" "fp$_Z16waka_func_theirsi$ii" (func $fimport$2 (type $0) (result i32)))
+ (import "env" "fp$_Z14waka_func_minei$ii" (func $fimport$3 (type $0) (result i32)))
  (global $global$0 (mut i32) (i32.const 0))
  (global $global$1 (mut i32) (i32.const 0))
  (global $global$2 (mut i32) (i32.const 0))
@@ -23,16 +23,16 @@
  (export "main" (func $3))
  (export "__dso_handle" (global $global$5))
  (export "__post_instantiate" (func $4))
- (func $0
+ (func $0 (type $1)
   (nop)
  )
- (func $1 (param $0 i32) (result i32)
+ (func $1 (type $2) (param $0 i32) (result i32)
   (i32.add
    (local.get $0)
    (i32.const 1)
   )
  )
- (func $2 (result i32)
+ (func $2 (type $0) (result i32)
   (i32.add
    (i32.load
     (global.get $global$3)
@@ -48,7 +48,7 @@
    )
   )
  )
- (func $3 (param $0 i32) (param $1 i32) (result i32)
+ (func $3 (type $3) (param $0 i32) (param $1 i32) (result i32)
   (i32.add
    (i32.load
     (global.get $global$3)
@@ -64,7 +64,7 @@
    )
   )
  )
- (func $4
+ (func $4 (type $1)
   (global.set $global$2
    (call $fimport$0)
   )

test/elided-br.wasm.fromBinary

@@ -1,6 +1,6 @@
 (module
  (type $0 (func))
- (func $0
+ (func $0 (type $0)
   (block $block
    (unreachable)
    (block

test/fib-dbg.wasm.fromBinary

@@ -48,7 +48,7 @@
  (export "stackRestore" (func $stackRestore))
  (export "_fib" (func $_fib))
  (export "stackAlloc" (func $stackAlloc))
- (func $stackAlloc (param $0 i32) (result i32)
+ (func $stackAlloc (type $0) (param $0 i32) (result i32)
   (local $1 i32)
   (block
    (local.set $1
@@ -76,25 +76,25 @@
   )
   (unreachable)
  )
- (func $stackSave (result i32)
+ (func $stackSave (type $2) (result i32)
   (return
    (global.get $global$3)
   )
  )
- (func $stackRestore (param $0 i32)
+ (func $stackRestore (type $3) (param $0 i32)
   (global.set $global$3
    (local.get $0)
   )
  )
- (func $establishStackSpace (param $0 i32) (param $1 i32)
+ (func $establishStackSpace (type $1) (param $0 i32) (param $1 i32)
   (global.set $global$3
    (local.get $0)
   )
   (global.set $global$4
    (local.get $1)
   )
  )
- (func $setThrew (param $0 i32) (param $1 i32)
+ (func $setThrew (type $1) (param $0 i32) (param $1 i32)
   (if
    (i32.eq
     (global.get $global$7)
@@ -110,7 +110,7 @@
    )
   )
  )
- (func $_fib (param $0 i32) (result i32)
+ (func $_fib (type $0) (param $0 i32) (result i32)
   (local $1 i32)
   (local $2 i32)
   (local $3 i32)
@@ -222,7 +222,7 @@
   (unreachable)
   ;;@ fib.c:8:0
  )
- (func $runPostSets
+ (func $runPostSets (type $4)
   (local $0 i32)
   (nop)
  )