Skip to content

Commit 75dce86

Browse files
committed
Replace sprintf with snprintf
Fixes #292
1 parent fc78c23 commit 75dce86

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/spss/readstat_por.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ ssize_t por_utf8_encode(const unsigned char *input, size_t input_len,
129129
}
130130
/* TODO - For some reason that replacement character isn't recognized
131131
* by some systems, so be prepared to insert an ASCII space instead */
132-
int printed = sprintf(output + offset, "%lc", codepoint);
132+
int printed = snprintf(output + offset, output_len - offset, "%lc", codepoint);
133133
if (printed > 0) {
134134
offset += printed;
135135
} else {

src/stata/readstat_dta_write.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -420,10 +420,10 @@ static readstat_error_t dta_emit_fmtlist(readstat_writer_t *writer, dta_ctx_t *c
420420
}
421421
char format[64];
422422
if (format_letter == 'g') {
423-
sprintf(format, "%%%s%d.0g", r_variable->alignment == READSTAT_ALIGNMENT_LEFT ? "-" : "",
423+
snprintf(format, sizeof(format), "%%%s%d.0g", r_variable->alignment == READSTAT_ALIGNMENT_LEFT ? "-" : "",
424424
display_width);
425425
} else {
426-
sprintf(format, "%%%s%ds",
426+
snprintf(format, sizeof(format), "%%%s%ds",
427427
r_variable->alignment == READSTAT_ALIGNMENT_LEFT ? "-" : "",
428428
display_width);
429429
}

0 commit comments

Comments
 (0)