Skip to content

Commit eb78a18

Browse files
committed
Tests: Align null return type for get_registered_src().
Update the test and the caller in load_script_module_textdomain() to match the ?string return type of WP_Script_Modules::get_registered_src(), which returns null (not false) for unregistered modules.
1 parent 44a1f56 commit eb78a18

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/wp-includes/l10n.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1300,7 +1300,7 @@ function load_script_module_textdomain( $id, $domain = 'default', $path = '' ) {
13001300

13011301
$src = wp_script_modules()->get_registered_src( $id );
13021302

1303-
if ( false === $src ) {
1303+
if ( null === $src ) {
13041304
return false;
13051305
}
13061306

tests/phpunit/tests/script-modules/wpScriptModules.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2618,15 +2618,15 @@ public function test_wp_set_script_module_translations_returns_false_for_unregis
26182618
}
26192619

26202620
/**
2621-
* Tests that get_registered_src() returns false for unregistered module.
2621+
* Tests that get_registered_src() returns null for unregistered module.
26222622
*
26232623
* @ticket 65015
26242624
*
26252625
* @covers WP_Script_Modules::get_registered_src
26262626
*/
2627-
public function test_get_registered_src_returns_false_for_unregistered_module() {
2627+
public function test_get_registered_src_returns_null_for_unregistered_module() {
26282628
$result = $this->script_modules->get_registered_src( 'unregistered-module' );
2629-
$this->assertFalse( $result );
2629+
$this->assertNull( $result );
26302630
}
26312631

26322632
/**

0 commit comments

Comments
 (0)