Fixes for runtime model mutation violations

Fixing runtime errors like:
ActionUI/ActionUI/Common/ActionUIModel.swift:79 Publishing changes from within view updates is not allowed, this will cause undefined behavior.

Fix 1 — WindowModalView.swift: Changed dialog binding setters to use ActionUIModel.shared.dismissDialog(windowUUID:) instead of directly mutating windowModel.windowDialog. This prevents state mutation during the SwiftUI render cycle when dismissing alerts/confirmation dialogs.

Fix 2 — WindowModel.swift: Removed @published from element and viewModels.
  - WindowModalView is the only @ObservedObject observer of WindowModel. It only needs to react to windowModal and windowDialog changes (to show/hide presentation modifiers). Those remain @published.
  - element and viewModels are only read as direct lookups — by FileLoadableView.body, WindowGroup, FileLoadableWindowGroupHelper, etc. — none of which use @ObservedObject observation on WindowModel. They read the current value at render time.
  - Individual ViewModel instances have their own ObservableObject for per-view reactivity (via objectWillChange.send() in setElementValue, setElementState, setElementProperty, etc.), so @published on the dictionary was redundant for runtime updates.
  - All load methods remain synchronous — no deferred DispatchQueue.main.async, so viewModels are immediately available when FileLoadableView.body executes, and tests work without changes.

Author: abra-code

ActionUI/Common/WindowModalView.swift

@@ -107,14 +107,14 @@ struct WindowModalView: SwiftUI.View {
     private var alertBinding: Binding<Bool> {
         Binding(
             get: { windowModel.windowDialog?.style == .alert },
-            set: { if !$0 { windowModel.windowDialog = nil } }
+            set: { if !$0 { ActionUIModel.shared.dismissDialog(windowUUID: windowUUID) } }
         )
     }
 
     private var confirmationBinding: Binding<Bool> {
         Binding(
             get: { windowModel.windowDialog?.style == .confirmationDialog },
-            set: { if !$0 { windowModel.windowDialog = nil } }
+            set: { if !$0 { ActionUIModel.shared.dismissDialog(windowUUID: windowUUID) } }
         )
     }
 

ActionUI/Common/WindowModel.swift

@@ -8,8 +8,8 @@ import Combine
 
 @MainActor
 class WindowModel: ObservableObject {
-    @Published var element: (any ActionUIElementBase)?
-    @Published var viewModels: [Int: ViewModel] = [:]
+    var element: (any ActionUIElementBase)?
+    var viewModels: [Int: ViewModel] = [:]
     /// Maps a LoadableView's element ID to set of child view IDs it loaded
     var loadedSubViewIDs: [Int: Set<Int>] = [:]
     /// Active window-level modal (sheet or fullScreenCover). Set by ActionUIModel.presentModal.
@@ -29,14 +29,14 @@ class WindowModel: ObservableObject {
         if format == "json" {
             let element = try JSONDecoder(logger: logger).decode(ActionUIElement.self, from: data)
             self.element = element
-            self.viewModels = populateViewModels(from: element) // Update self.viewModels
+            self.viewModels = populateViewModels(from: element)
             self.loadedSubViewIDs = [:]
             logger.log("Loaded JSON description for windowUUID: \(windowUUID), element id: \(element.id)", .verbose)
             return element
         } else if format == "plist" {
             let element = try PropertyListDecoder(logger: logger).decode(ActionUIElement.self, from: data)
             self.element = element
-            self.viewModels = populateViewModels(from: element) // Update self.viewModels
+            self.viewModels = populateViewModels(from: element)
             self.loadedSubViewIDs = [:]
             logger.log("Loaded plist description for windowUUID: \(windowUUID), element id: \(element.id)", .verbose)
             return element
@@ -50,7 +50,7 @@ class WindowModel: ObservableObject {
     func loadDescription(from dict: [String: Any]) throws -> ActionUIElement {
         let element = try ActionUIElement(from: dict, logger: logger)
         self.element = element
-        self.viewModels = populateViewModels(from: element) // Update self.viewModels
+        self.viewModels = populateViewModels(from: element)
         self.loadedSubViewIDs = [:]
         return element
     }
@@ -88,7 +88,7 @@ class WindowModel: ObservableObject {
         }
 
         // Merge subViewModels into main viewModels, ensuring no ID conflicts.
-        // Build the merged dictionary first, then assign once to fire a single @Published notification.
+        // Build the merged dictionary first, then assign once.
         var merged = self.viewModels
         for (id, viewModel) in subViewModels {
             if merged[id] == nil {