Skip to content

Commit 56a71ff

Browse files
committed
Fix unit tests for drag and drop
This is related to property validation. it was a test deficiency, not implementation issue.
1 parent 8e5903a commit 56a71ff

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

ActionUITests/Views/HoverDropTests.swift

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -198,10 +198,15 @@ final class HoverDropTests: XCTestCase {
198198
return
199199
}
200200
let element = try ActionUIModel.shared.loadDescription(from: jsonData, format: "json", windowUUID: windowUUID)
201-
XCTAssertNil(element.properties["onHoverActionID"], "Invalid onHoverActionID should be discarded")
202-
XCTAssertNil(element.properties["onDropActionID"], "Invalid onDropActionID should be discarded")
203-
XCTAssertNil(element.properties["onDropTypes"], "Invalid onDropTypes should be discarded")
204-
XCTAssertNil(element.properties["onDropTargetedActionID"], "Invalid onDropTargetedActionID should be discarded")
201+
guard let windowModel = ActionUIModel.shared.windowModels[windowUUID],
202+
let viewModel = windowModel.viewModels[element.id] else {
203+
XCTFail("Failed to retrieve viewModel")
204+
return
205+
}
206+
XCTAssertNil(viewModel.validatedProperties["onHoverActionID"], "Invalid onHoverActionID should be discarded")
207+
XCTAssertNil(viewModel.validatedProperties["onDropActionID"], "Invalid onDropActionID should be discarded")
208+
XCTAssertNil(viewModel.validatedProperties["onDropTypes"], "Invalid onDropTypes should be discarded")
209+
XCTAssertNil(viewModel.validatedProperties["onDropTargetedActionID"], "Invalid onDropTargetedActionID should be discarded")
205210
}
206211

207212
// MARK: - View construction

0 commit comments

Comments
 (0)