fix controller and health checks

Author: janishar

api/health/controller.go

@@ -20,7 +20,7 @@ func NewController(
 }
 
 func (c *controller) MountRoutes(group *gin.RouterGroup) {
-	group.GET("/", c.getHealthHandler)
+	group.GET("", c.getHealthHandler)
 }
 
 func (c *controller) getHealthHandler(ctx *gin.Context) {

docker-compose.yml

@@ -36,10 +36,15 @@ services:
     networks:
       - goserve-postgres-network
     healthcheck:
-      test: ["CMD-SHELL", "pg_isready -U $$POSTGRES_USER -d $$DB_NAME"]
-      interval: 3s
-      timeout: 3s
-      retries: 10
+      test:
+        [
+          "CMD-SHELL",
+          "pg_isready -h localhost -p 5432 -U \"$${POSTGRES_USER}\" -d \"$${POSTGRES_DB}\""
+        ]
+      interval: 10s
+      timeout: 5s
+      retries: 5
+      start_period: 20s
 
   redis:
     image: redis:8.4.0
@@ -53,10 +58,17 @@ services:
     networks:
       - goserve-postgres-network
     healthcheck:
-      test: ["CMD-SHELL", "redis-cli -a ${REDIS_PASSWORD} ping | grep PONG"]
-      interval: 5s
+      test:
+        [
+          "CMD",
+          "redis-cli",
+          "-a", "${REDIS_PASSWORD}",
+          "ping"
+        ]
+      interval: 10s
       timeout: 3s
       retries: 5
+      start_period: 10s
 
   migrate:
     image: migrate/migrate

startup/module.go

@@ -36,9 +36,13 @@ func (m *module) GetInstance() *module {
 	return m
 }
 
+// OpenControllers are controllers that do not require api key authentication
+func (m *module) OpenControllers() []network.Controller {
+	return []network.Controller{health.NewController(m.HealthService)}
+}
+
 func (m *module) Controllers() []network.Controller {
 	return []network.Controller{
-		health.NewController(m.HealthService),
 		auth.NewController(m.AuthenticationProvider(), m.AuthorizationProvider(), m.AuthService),
 		user.NewController(m.AuthenticationProvider(), m.AuthorizationProvider(), m.UserService),
 		blog.NewController(m.AuthenticationProvider(), m.AuthorizationProvider(), m.BlogService),

startup/server.go

@@ -50,6 +50,7 @@ func create(env *config.Env) (network.Router, Module, Shutdown) {
 
 	router := network.NewRouter(env.GoMode)
 	router.RegisterValidationParsers(network.CustomTagNameFunc())
+	router.LoadControllers(module.GetInstance().OpenControllers())
 	router.LoadRootMiddlewares(module.RootMiddlewares())
 	router.LoadControllers(module.Controllers())