Stop using download_url in item viewer

Author: dima-aignostics

src/aignostics/application/_gui/_page_application_run_describe.py

@@ -15,9 +15,10 @@
 )
 from nicegui import run as nicegui_run
 
-from aignostics.platform import ItemOutput, ItemResult, ItemState, RunState
+from aignostics.platform import ItemOutput, ItemResult, ItemState, RunState, Run
 from aignostics.third_party.showinfm.showinfm import show_in_file_manager
 from aignostics.utils import GUILocalFilePicker, get_user_data_directory
+from aignx.codegen.models import ArtifactOutput
 
 if TYPE_CHECKING:
     from aignx.codegen.models import RunReadResponse
@@ -430,9 +431,10 @@ def csv_view_dialog_content(title: str | None, url: str | None) -> None:
         with ui.row(align_items="end").classes("w-full"), ui.column(align_items="end").classes("w-full"):
             ui.button("Close", on_click=csv_view_dialog.close)
 
-    def csv_dialog_open(title: str, url: str) -> None:
+    def csv_dialog_open(title: str, artifact_id: str) -> None:
         """Open the CSV dialog."""
-        csv_view_dialog_content.refresh(title=title, url=url)
+        download_url = Run.for_run_id(run_id).get_artifact_download_url(artifact_id)
+        csv_view_dialog_content.refresh(title=title, url=download_url)
         csv_view_dialog.open()
 
     @ui.refreshable
@@ -478,15 +480,16 @@ def tiff_view_dialog_content(title: str | None, url: str | None) -> None:
         with ui.row(align_items="end").classes("w-full"), ui.column(align_items="end").classes("w-full"):
             ui.button("Close", on_click=tiff_view_dialog.close)
 
-    def tiff_dialog_open(title: str, url: str) -> None:
+    def tiff_dialog_open(title: str, artifact_id: str) -> None:
         """Open the TIFF dialog.
 
         Args:
             title (str): The title of the TIFF dialog.
-            url (str): The URL of the TIFF image.
+            artifact_id: (str): The ID of the artifact containing the TIFF to display.
 
         """
-        tiff_view_dialog_content.refresh(title=title, url=url)
+        download_url = Run.for_run_id(run_id).get_artifact_download_url(artifact_id)
+        tiff_view_dialog_content.refresh(title=title, url=download_url)
         tiff_view_dialog.open()
 
     @ui.refreshable
@@ -516,6 +519,10 @@ def custom_metadata_dialog_open(title: str, custom_metadata: dict[str, Any]) ->
         custom_metadata_dialog_content.refresh(title=title, custom_metadata=custom_metadata)
         custom_metadata_dialog.open()
 
+    def open_browser(_, artifact_id):
+        download_url = Run.for_run_id(run_id).get_artifact_download_url(artifact_id)
+        webbrowser.open(download_url)
+
     async def open_qupath(
         project: Path | None = None, image: Path | str | None = None, button: ui.button | None = None
     ) -> None:
@@ -760,29 +767,28 @@ def render_item(item: ItemResult) -> None:  # noqa: C901, PLR0912, PLR0915
                                 icon=mime_type_to_icon(mime_type),
                                 group="artifacts",
                             ).classes("w-full"):
-                                if artifact.download_url:
-                                    url = artifact.download_url
+                                if artifact.output == ArtifactOutput.AVAILABLE:
+                                    artifact_id = artifact.output_artifact_id
                                     title = artifact.name
                                     metadata = artifact.metadata
                                     with ui.button_group():
                                         if mime_type == "image/tiff":
                                             ui.button(
                                                 "Preview",
                                                 icon=mime_type_to_icon(mime_type),
-                                                on_click=lambda _, url=url, title=title: tiff_dialog_open(title, url),
+                                                on_click=lambda _, artifact_id=artifact_id, title=title: tiff_dialog_open(title, artifact_id),
                                             )
                                         if mime_type == "text/csv":
                                             ui.button(
                                                 "Preview",
                                                 icon=mime_type_to_icon(mime_type),
-                                                on_click=lambda _, url=url, title=title: csv_dialog_open(title, url),
-                                            )
-                                        if url:
-                                            ui.button(
-                                                text="Download",
-                                                icon="cloud_download",
-                                                on_click=lambda _, url=url: webbrowser.open(url),
+                                                on_click=lambda _, artifact_id=artifact_id, title=title: csv_dialog_open(title, artifact_id),
                                             )
+                                        ui.button(
+                                            text="Download",
+                                            icon="cloud_download",
+                                            on_click=lambda _, artifact_id=artifact_id: open_browser(_, artifact_id),
+                                        )
                                         if metadata:
                                             ui.button(
                                                 text="Schema",

src/aignostics/application/_utils.py

@@ -325,7 +325,6 @@ def _retrieve_and_print_run_items(run_handle: Run, summarize: bool = False) -> N
                     f"\n    - Name: {artifact.name}"
                     f"\n      MIME Type: {get_mime_type_for_artifact(artifact)}"
                     f"\n      Artifact ID: {artifact.output_artifact_id}"
-                    f"\n      Download URL: {artifact.download_url}"
                 )
             item_output += artifacts_output