increase test coverage

Author: na66im

packages/sdk/src/platform-sdk.test.ts

@@ -1,9 +1,10 @@
 import { describe, it, expect, beforeEach, vi } from 'vitest';
 import { http, HttpResponse } from 'msw';
 import { PlatformSDKHttp } from './platform-sdk.js';
-import { AuthenticationError } from './errors.js';
+import { APIError, AuthenticationError, UnexpectedError } from './errors.js';
 import { setMockScenario, server } from './test-utils/http-mocks.js';
 import { ItemState, ItemTerminationReason } from './generated/api.js';
+import { PublicApi } from './generated/index.js';
 
 describe('PlatformSDK', () => {
   let sdk: PlatformSDKHttp;
@@ -601,4 +602,50 @@ describe('PlatformSDK', () => {
     );
     expect(callCount).toBe(1);
   });
+
+  it('should throw APIError with 422 status when validation error occurs', async () => {
+    mockTokenProvider.mockResolvedValue('mocked-token');
+    setMockScenario('validationError');
+
+    await expect(sdk.listApplications()).rejects.toThrow(APIError);
+    await expect(sdk.listApplications()).rejects.toThrow('Validation error:');
+  });
+
+  it('should throw APIError with 403 status when access is forbidden', async () => {
+    mockTokenProvider.mockResolvedValue('mocked-token');
+
+    server.use(
+      http.get('*/v1/applications', () => {
+        return HttpResponse.json({ detail: 'Forbidden' }, { status: 403 });
+      })
+    );
+
+    await expect(sdk.listApplications()).rejects.toThrow(APIError);
+    await expect(sdk.listApplications()).rejects.toThrow('Access forbidden:');
+  });
+
+  it('should throw APIError with 410 status when resource is gone', async () => {
+    mockTokenProvider.mockResolvedValue('mocked-token');
+
+    server.use(
+      http.get('*/v1/runs/:runId', () => {
+        return HttpResponse.json({ detail: 'Gone' }, { status: 410 });
+      })
+    );
+
+    await expect(sdk.getRun('test-run-id')).rejects.toThrow(APIError);
+    await expect(sdk.getRun('test-run-id')).rejects.toThrow('Resource gone:');
+  });
+
+  it('should throw UnexpectedError for non-axios errors', async () => {
+    mockTokenProvider.mockResolvedValue('mocked-token');
+
+    vi.spyOn(PublicApi.prototype, 'listApplicationsV1ApplicationsGet').mockRejectedValueOnce(
+      new RangeError('unexpected internal failure')
+    );
+
+    const error = await sdk.listApplications().catch((e) => e);
+    expect(error).toBeInstanceOf(UnexpectedError);
+    expect(error.message).toContain('Unexpected error:');
+  });
 });

packages/sdk/src/utils/downloadWithRetry.spec.ts

@@ -0,0 +1,50 @@
+import { describe, it, expect, vi } from 'vitest';
+import axios, { AxiosHeaders } from 'axios';
+import { downloadWithRetry } from './downloadWithRetry.js';
+
+describe('downloadWithRetry', () => {
+  it('should retry non-axios errors and succeed on second attempt', async () => {
+    let callCount = 0;
+    const nonAxiosError = new Error('transient non-axios error');
+    const mockFn = vi.fn().mockImplementation(async () => {
+      callCount++;
+      if (callCount === 1) {
+        throw nonAxiosError;
+      }
+      return {
+        data: new ArrayBuffer(4),
+        status: 200,
+        statusText: 'OK',
+        headers: new AxiosHeaders(),
+        config: { headers: new AxiosHeaders() },
+      };
+    });
+
+    const result = await downloadWithRetry(mockFn);
+    expect(result.status).toBe(200);
+    expect(callCount).toBe(2);
+  }, 10_000);
+
+  it('should retry axios error with no response (network error) and succeed on second attempt', async () => {
+    let callCount = 0;
+    const networkError = new axios.AxiosError('Network Error', 'ERR_NETWORK');
+    // networkError.response is undefined — triggers the `?? 0` fallback
+    const mockFn = vi.fn().mockImplementation(async () => {
+      callCount++;
+      if (callCount === 1) {
+        throw networkError;
+      }
+      return {
+        data: new ArrayBuffer(4),
+        status: 200,
+        statusText: 'OK',
+        headers: new AxiosHeaders(),
+        config: { headers: new AxiosHeaders() },
+      };
+    });
+
+    const result = await downloadWithRetry(mockFn);
+    expect(result.status).toBe(200);
+    expect(callCount).toBe(2);
+  }, 10_000);
+});