Redundant string length computations

Author: Gintas Grigelionis

src/main/org/apache/tools/ant/Main.java

@@ -549,7 +549,7 @@ private int handleArgDefine(final String[] args, int argPos) {
          * to help or not, so we simply look for the equals sign.
          */
         final String arg = args[argPos];
-        String name = arg.substring(2, arg.length());
+        String name = arg.substring(2);
         String value;
         final int posEq = name.indexOf('=');
         if (posEq > 0) {

src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogParser.java

@@ -171,7 +171,7 @@ private void processComment(final String line) {
     private void processFile(final String line) {
         if (!remote && line.startsWith("Working file:")) {
             // CheckStyle:MagicNumber OFF
-            file = line.substring(14, line.length());
+            file = line.substring(14);
             // CheckStyle:MagicNumber ON
             status = GET_REVISION;
         } else if (remote && line.startsWith("RCS file:")) {

src/main/org/apache/tools/ant/taskdefs/optional/ejb/BorlandDeploymentTool.java

@@ -202,23 +202,17 @@ public void setJava2iiopParams(String params) {
      * @return the descriptor.
      */
     protected DescriptorHandler getBorlandDescriptorHandler(final File srcDir) {
-        DescriptorHandler handler =
-            new DescriptorHandler(getTask(), srcDir) {
-                    @Override
-                    protected void processElement() {
-                        if ("type-storage".equals(currentElement)) {
-                            // Get the filename of vendor specific descriptor
-                            String fileNameWithMETA = currentText;
-                            //trim the META_INF\ off of the file name
-                            String fileName
-                                = fileNameWithMETA.substring(META_DIR.length(),
-                                    fileNameWithMETA.length());
-                            File descriptorFile = new File(srcDir, fileName);
-
-                            ejbFiles.put(fileNameWithMETA, descriptorFile);
-                        }
-                    }
-                };
+        DescriptorHandler handler = new DescriptorHandler(getTask(), srcDir) {
+            @Override
+            protected void processElement() {
+                if ("type-storage".equals(currentElement)) {
+                    // Get the filename of vendor specific descriptor
+                    // trim the META_INF\ off of the file name
+                    ejbFiles.put(currentText, new File(srcDir,
+                            currentText.substring(META_DIR.length())));
+                }
+            }
+        };
         handler.registerDTD(PUBLICID_BORLAND_EJB,
                             borlandDTD == null ? DEFAULT_BAS_DTD_LOCATION : borlandDTD);
 

src/main/org/apache/tools/ant/taskdefs/optional/ejb/WeblogicDeploymentTool.java

@@ -401,23 +401,17 @@ protected void registerKnownDTDs(DescriptorHandler handler) {
      * @return the descriptor.
      */
     protected DescriptorHandler getWeblogicDescriptorHandler(final File srcDir) {
-        DescriptorHandler handler =
-            new DescriptorHandler(getTask(), srcDir) {
-                @Override
-                protected void processElement() {
-                    if ("type-storage".equals(currentElement)) {
-                        // Get the filename of vendor specific descriptor
-                        String fileNameWithMETA = currentText;
-                        //trim the META_INF\ off of the file name
-                        String fileName
-                             = fileNameWithMETA.substring(META_DIR.length(),
-                            fileNameWithMETA.length());
-                        File descriptorFile = new File(srcDir, fileName);
-
-                        ejbFiles.put(fileNameWithMETA, descriptorFile);
-                    }
+        DescriptorHandler handler = new DescriptorHandler(getTask(), srcDir) {
+            @Override
+            protected void processElement() {
+                if ("type-storage".equals(currentElement)) {
+                    // Get the filename of vendor specific descriptor
+                    // trim the META_INF\ off of the file name
+                    ejbFiles.put(currentText, new File(srcDir,
+                            currentText.substring(META_DIR.length())));
                 }
-            };
+            }
+        };
 
         handler.registerDTD(PUBLICID_WEBLOGIC_EJB510, DEFAULT_WL51_DTD_LOCATION);
         handler.registerDTD(PUBLICID_WEBLOGIC_EJB510, DEFAULT_WL60_51_DTD_LOCATION);

src/main/org/apache/tools/ant/types/resources/JavaConstantResource.java

@@ -47,7 +47,7 @@ protected InputStream openInputStream(ClassLoader cl) throws IOException {
             throw new IOException("No class name in " + constant);
         }
         String classname = constant.substring(0, index);
-        String fieldname = constant.substring(index + 1, constant.length());
+        String fieldname = constant.substring(index + 1);
         try {
             Class<?> clazz =
                 cl != null

src/main/org/apache/tools/ant/util/FileUtils.java

@@ -858,7 +858,7 @@ public String toVMSPath(File f) {
         if (isDirectory) {
             directory = new StringBuilder(path.substring(index).replace(File.separatorChar, '.'));
         } else {
-            int dirEnd = path.lastIndexOf(File.separatorChar, path.length());
+            int dirEnd = path.lastIndexOf(File.separatorChar);
             if (dirEnd == -1 || dirEnd < index) {
                 file = path.substring(index);
             } else {

src/main/org/apache/tools/ant/util/LayoutPreservingProperties.java

@@ -724,7 +724,7 @@ private void parsePair(final String text) {
                 setValue(null);
             } else {
                 name = text.substring(0, pos);
-                setValue(text.substring(pos + 1, text.length()));
+                setValue(text.substring(pos + 1));
             }
             // trim leading whitespace only
             name = stripStart(name, " \t\f");

src/tests/junit/org/apache/tools/ant/taskdefs/XmlPropertyTest.java

@@ -229,7 +229,7 @@ private static void ensureProperties(String msg, File inputFile,
                 assertNotEquals(assertMsg + " Object ID does not exist.", null, obj);
 
                 // What is the property supposed to be?
-                propertyValue = propertyValue.substring(3, propertyValue.length());
+                propertyValue = propertyValue.substring(3);
                 if (propertyValue.equals("path")) {
                     assertThat(assertMsg + " Path ID is a " + obj.getClass().getName(),
                             obj, instanceOf(Path.class));
@@ -243,8 +243,7 @@ private static void ensureProperties(String msg, File inputFile,
                     // The property is the name of a file.  We are testing
                     // a location attribute, so we need to resolve the given
                     // file name in the provided folder.
-                    String fileName =
-                        propertyValue.substring(5, propertyValue.length());
+                    String fileName = propertyValue.substring(5);
                     File f = new File(workingDir, fileName);
                     propertyValue = f.getAbsolutePath();
                 }