Skip to content

Commit 00a30c6

Browse files
authored
MINOR: [C++] Remove obsolete TODO comment from mode kernel registration (#49122)
### Rationale for this change The TODO comment was added in commit 53752ad during the ExecSpan refactoring. It was, presumably, a reminder to migrate the mode kernel from the old `GenerateNumericOld` API to the new `GenerateNumeric` API. This migration was completed in commit 4d931ff, but the TODO comment was accidentally left behind. ### What changes are included in this PR? Removed the orphaned `// TODO(wesm):` comment from `aggregate_mode.cc`. The work it referenced was completed. ### Are these changes tested? No, I did not test. ### Are there any user-facing changes? No. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Nic Crane <thisisnic@gmail.com>
1 parent 07a0aa3 commit 00a30c6

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

cpp/src/arrow/compute/kernels/aggregate_mode.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,6 @@ void RegisterScalarAggregateMode(FunctionRegistry* registry) {
495495
NewModeKernel(boolean(), ModeExecutor<StructType, BooleanType>::Exec,
496496
ModeExecutorChunked<StructType, BooleanType>::Exec)));
497497
for (const auto& type : NumericTypes()) {
498-
// TODO(wesm):
499498
DCHECK_OK(func->AddKernel(
500499
NewModeKernel(type, GenerateNumeric<ModeExecutor, StructType>(*type),
501500
GenerateNumeric<ModeExecutorChunked, StructType>(*type))));

0 commit comments

Comments
 (0)