Skip to content

Commit dd1ad53

Browse files
vishesh92vishesh92
authored
Force some param to be required (#79)
Force parameters to be required to maintain backward compatability
1 parent afbda39 commit dd1ad53

24 files changed

Lines changed: 148 additions & 75 deletions

‎Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ SHELL = /usr/bin/env bash -o pipefail
1414
all: code mocks test
1515

1616
code:
17-
go run generate/generate.go generate/layout.go --api=generate/listApis.json
17+
go run generate/generate.go generate/layout.go generate/requiredParams.go --api=generate/listApis.json
1818

1919
FILES=$(shell for file in `pwd`/cloudstack/*Service.go ;do basename $$file .go ; done)
2020
mocks:

‎cloudstack/DiskOfferingService.go‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import (
2929

3030
type DiskOfferingServiceIface interface {
3131
CreateDiskOffering(p *CreateDiskOfferingParams) (*CreateDiskOfferingResponse, error)
32-
NewCreateDiskOfferingParams(name string) *CreateDiskOfferingParams
32+
NewCreateDiskOfferingParams(displaytext string, name string) *CreateDiskOfferingParams
3333
DeleteDiskOffering(p *DeleteDiskOfferingParams) (*DeleteDiskOfferingResponse, error)
3434
NewDeleteDiskOfferingParams(id string) *DeleteDiskOfferingParams
3535
ListDiskOfferings(p *ListDiskOfferingsParams) (*ListDiskOfferingsResponse, error)
@@ -639,9 +639,10 @@ func (p *CreateDiskOfferingParams) GetZoneid() ([]string, bool) {
639639

640640
// You should always use this function to get a new CreateDiskOfferingParams instance,
641641
// as then you are sure you have configured all required params
642-
func (s *DiskOfferingService) NewCreateDiskOfferingParams(name string) *CreateDiskOfferingParams {
642+
func (s *DiskOfferingService) NewCreateDiskOfferingParams(displaytext string, name string) *CreateDiskOfferingParams {
643643
p := &CreateDiskOfferingParams{}
644644
p.p = make(map[string]interface{})
645+
p.p["displaytext"] = displaytext
645646
p.p["name"] = name
646647
return p
647648
}

‎cloudstack/DiskOfferingService_mock.go‎

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎cloudstack/ISOService.go‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ type ISOServiceIface interface {
4747
GetIsoByName(name string, isofilter string, zoneid string, opts ...OptionFunc) (*Iso, int, error)
4848
GetIsoByID(id string, opts ...OptionFunc) (*Iso, int, error)
4949
RegisterIso(p *RegisterIsoParams) (*RegisterIsoResponse, error)
50-
NewRegisterIsoParams(name string, url string, zoneid string) *RegisterIsoParams
50+
NewRegisterIsoParams(displaytext string, name string, url string, zoneid string) *RegisterIsoParams
5151
UpdateIso(p *UpdateIsoParams) (*UpdateIsoResponse, error)
5252
NewUpdateIsoParams(id string) *UpdateIsoParams
5353
UpdateIsoPermissions(p *UpdateIsoPermissionsParams) (*UpdateIsoPermissionsResponse, error)
@@ -2082,9 +2082,10 @@ func (p *RegisterIsoParams) GetZoneid() (string, bool) {
20822082

20832083
// You should always use this function to get a new RegisterIsoParams instance,
20842084
// as then you are sure you have configured all required params
2085-
func (s *ISOService) NewRegisterIsoParams(name string, url string, zoneid string) *RegisterIsoParams {
2085+
func (s *ISOService) NewRegisterIsoParams(displaytext string, name string, url string, zoneid string) *RegisterIsoParams {
20862086
p := &RegisterIsoParams{}
20872087
p.p = make(map[string]interface{})
2088+
p.p["displaytext"] = displaytext
20882089
p.p["name"] = name
20892090
p.p["url"] = url
20902091
p.p["zoneid"] = zoneid

‎cloudstack/ISOService_mock.go‎

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎cloudstack/NetworkOfferingService.go‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import (
2929

3030
type NetworkOfferingServiceIface interface {
3131
CreateNetworkOffering(p *CreateNetworkOfferingParams) (*CreateNetworkOfferingResponse, error)
32-
NewCreateNetworkOfferingParams(guestiptype string, name string, traffictype string) *CreateNetworkOfferingParams
32+
NewCreateNetworkOfferingParams(displaytext string, guestiptype string, name string, traffictype string) *CreateNetworkOfferingParams
3333
DeleteNetworkOffering(p *DeleteNetworkOfferingParams) (*DeleteNetworkOfferingResponse, error)
3434
NewDeleteNetworkOfferingParams(id string) *DeleteNetworkOfferingParams
3535
ListNetworkOfferings(p *ListNetworkOfferingsParams) (*ListNetworkOfferingsResponse, error)
@@ -530,9 +530,10 @@ func (p *CreateNetworkOfferingParams) GetZoneid() ([]string, bool) {
530530

531531
// You should always use this function to get a new CreateNetworkOfferingParams instance,
532532
// as then you are sure you have configured all required params
533-
func (s *NetworkOfferingService) NewCreateNetworkOfferingParams(guestiptype string, name string, traffictype string) *CreateNetworkOfferingParams {
533+
func (s *NetworkOfferingService) NewCreateNetworkOfferingParams(displaytext string, guestiptype string, name string, traffictype string) *CreateNetworkOfferingParams {
534534
p := &CreateNetworkOfferingParams{}
535535
p.p = make(map[string]interface{})
536+
p.p["displaytext"] = displaytext
536537
p.p["guestiptype"] = guestiptype
537538
p.p["name"] = name
538539
p.p["traffictype"] = traffictype

‎cloudstack/NetworkOfferingService_mock.go‎

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎cloudstack/ProjectService.go‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ type ProjectServiceIface interface {
3535
AddUserToProject(p *AddUserToProjectParams) (*AddUserToProjectResponse, error)
3636
NewAddUserToProjectParams(projectid string, username string) *AddUserToProjectParams
3737
CreateProject(p *CreateProjectParams) (*CreateProjectResponse, error)
38-
NewCreateProjectParams(name string) *CreateProjectParams
38+
NewCreateProjectParams(displaytext string, name string) *CreateProjectParams
3939
DeleteAccountFromProject(p *DeleteAccountFromProjectParams) (*DeleteAccountFromProjectResponse, error)
4040
NewDeleteAccountFromProjectParams(account string, projectid string) *DeleteAccountFromProjectParams
4141
DeleteUserFromProject(p *DeleteUserFromProjectParams) (*DeleteUserFromProjectResponse, error)
@@ -612,9 +612,10 @@ func (p *CreateProjectParams) GetUserid() (string, bool) {
612612

613613
// You should always use this function to get a new CreateProjectParams instance,
614614
// as then you are sure you have configured all required params
615-
func (s *ProjectService) NewCreateProjectParams(name string) *CreateProjectParams {
615+
func (s *ProjectService) NewCreateProjectParams(displaytext string, name string) *CreateProjectParams {
616616
p := &CreateProjectParams{}
617617
p.p = make(map[string]interface{})
618+
p.p["displaytext"] = displaytext
618619
p.p["name"] = name
619620
return p
620621
}

‎cloudstack/ProjectService_mock.go‎

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎cloudstack/ServiceOfferingService.go‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import (
2929

3030
type ServiceOfferingServiceIface interface {
3131
CreateServiceOffering(p *CreateServiceOfferingParams) (*CreateServiceOfferingResponse, error)
32-
NewCreateServiceOfferingParams(name string) *CreateServiceOfferingParams
32+
NewCreateServiceOfferingParams(displaytext string, name string) *CreateServiceOfferingParams
3333
DeleteServiceOffering(p *DeleteServiceOfferingParams) (*DeleteServiceOfferingResponse, error)
3434
NewDeleteServiceOfferingParams(id string) *DeleteServiceOfferingParams
3535
ListServiceOfferings(p *ListServiceOfferingsParams) (*ListServiceOfferingsResponse, error)
@@ -940,9 +940,10 @@ func (p *CreateServiceOfferingParams) GetZoneid() ([]string, bool) {
940940

941941
// You should always use this function to get a new CreateServiceOfferingParams instance,
942942
// as then you are sure you have configured all required params
943-
func (s *ServiceOfferingService) NewCreateServiceOfferingParams(name string) *CreateServiceOfferingParams {
943+
func (s *ServiceOfferingService) NewCreateServiceOfferingParams(displaytext string, name string) *CreateServiceOfferingParams {
944944
p := &CreateServiceOfferingParams{}
945945
p.p = make(map[string]interface{})
946+
p.p["displaytext"] = displaytext
946947
p.p["name"] = name
947948
return p
948949
}

0 commit comments

Comments
 (0)