Skip to content

Commit 38ca11f

Browse files
committed
build: fix build failure after merge-forward
1 parent 63a0797 commit 38ca11f

2 files changed

Lines changed: 7 additions & 9 deletions

File tree

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtDomainListener.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
package com.cloud.hypervisor.kvm.resource;
1616

1717
import com.cloud.resource.AgentStatusUpdater;
18-
import org.apache.log4j.Logger;
18+
import org.apache.logging.log4j.Logger;
19+
import org.apache.logging.log4j.LogManager;
1920
import org.libvirt.Domain;
2021
import org.libvirt.LibvirtException;
2122
import org.libvirt.event.DomainEvent;
@@ -24,7 +25,7 @@
2425
import org.libvirt.event.StoppedDetail;
2526

2627
public class LibvirtDomainListener implements LifecycleListener {
27-
private static final Logger LOGGER = Logger.getLogger(LibvirtDomainListener.class);
28+
private static final Logger LOGGER = LogManager.getLogger(LibvirtDomainListener.class);
2829

2930
private final AgentStatusUpdater agentStatusUpdater;
3031

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCheckAndRepairVolumeCommandWrapper.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
import org.apache.cloudstack.utils.qemu.QemuObject.EncryptFormat;
4343
import org.apache.commons.lang.ArrayUtils;
4444
import org.apache.commons.lang3.StringUtils;
45-
import org.apache.log4j.Logger;
4645
import org.libvirt.LibvirtException;
4746

4847
import java.io.IOException;
@@ -53,8 +52,6 @@
5352
@ResourceWrapper(handles = CheckAndRepairVolumeCommand.class)
5453
public class LibvirtCheckAndRepairVolumeCommandWrapper extends CommandWrapper<CheckAndRepairVolumeCommand, Answer, LibvirtComputingResource> {
5554

56-
private static final Logger s_logger = Logger.getLogger(LibvirtCheckAndRepairVolumeCommandWrapper.class);
57-
5855
@Override
5956
public Answer execute(CheckAndRepairVolumeCommand command, LibvirtComputingResource serverResource) {
6057
final String volumeId = command.getPath();
@@ -105,7 +102,7 @@ private CheckAndRepairVolumeAnswer checkVolume(KVMPhysicalDisk vol, CheckAndRepa
105102
EncryptFormat encryptFormat = EncryptFormat.enumValue(command.getEncryptFormat());
106103
byte[] passphrase = command.getPassphrase();
107104
String checkVolumeResult = checkAndRepairVolume(vol, null, encryptFormat, passphrase, serverResource);
108-
s_logger.info(String.format("Check Volume result for the volume %s is %s", vol.getName(), checkVolumeResult));
105+
logger.info(String.format("Check Volume result for the volume %s is %s", vol.getName(), checkVolumeResult));
109106
CheckAndRepairVolumeAnswer answer = new CheckAndRepairVolumeAnswer(command, true, checkVolumeResult);
110107
answer.setVolumeCheckExecutionResult(checkVolumeResult);
111108

@@ -119,7 +116,7 @@ private CheckAndRepairVolumeAnswer repairVolume(KVMPhysicalDisk vol, CheckAndRep
119116

120117
String repairVolumeResult = checkAndRepairVolume(vol, repair, encryptFormat, passphrase, serverResource);
121118
String finalResult = (checkVolumeResult != null ? checkVolumeResult.concat(",") : "") + repairVolumeResult;
122-
s_logger.info(String.format("Repair Volume result for the volume %s is %s", vol.getName(), repairVolumeResult));
119+
logger.info(String.format("Repair Volume result for the volume %s is %s", vol.getName(), repairVolumeResult));
123120

124121
CheckAndRepairVolumeAnswer answer = new CheckAndRepairVolumeAnswer(command, true, finalResult);
125122
answer.setVolumeRepairExecutionResult(repairVolumeResult);
@@ -138,7 +135,7 @@ private CheckAndRepairVolumeAnswer checkIfRepairLeaksIsRequired(CheckAndRepairVo
138135
jsonNode = objectMapper.readTree(checkVolumeResult);
139136
} catch (JsonProcessingException e) {
140137
String msg = String.format("Error processing response %s during check volume %s", checkVolumeResult, e.getMessage());
141-
s_logger.info(msg);
138+
logger.info(msg);
142139

143140
return skipRepairVolumeCommand(command, checkVolumeResult, msg);
144141
}
@@ -157,7 +154,7 @@ private CheckAndRepairVolumeAnswer checkIfRepairLeaksIsRequired(CheckAndRepairVo
157154
}
158155

159156
private CheckAndRepairVolumeAnswer skipRepairVolumeCommand(CheckAndRepairVolumeCommand command, String checkVolumeResult, String msg) {
160-
s_logger.info(msg);
157+
logger.info(msg);
161158
String jsonStringFormat = String.format("{ \"message\": \"%s\" }", msg);
162159
String finalResult = (checkVolumeResult != null ? checkVolumeResult.concat(",") : "") + jsonStringFormat;
163160
CheckAndRepairVolumeAnswer answer = new CheckAndRepairVolumeAnswer(command, true, finalResult);

0 commit comments

Comments
 (0)