Fixed minor issues

Author: avbasak1

commons-math4-genetics/src/main/java/org/apache/commons/math4/genetics/AbstractGeneticAlgorithm.java

@@ -56,7 +56,7 @@ public abstract class AbstractGeneticAlgorithm<P> {
      * @param mutationPolicy  The {@link MutationPolicy}
      * @param selectionPolicy The {@link SelectionPolicy}
      */
-    public AbstractGeneticAlgorithm(final CrossoverPolicy<P> crossoverPolicy, final MutationPolicy<P> mutationPolicy,
+    protected AbstractGeneticAlgorithm(final CrossoverPolicy<P> crossoverPolicy, final MutationPolicy<P> mutationPolicy,
             final SelectionPolicy<P> selectionPolicy) {
         this.crossoverPolicy = crossoverPolicy;
         this.mutationPolicy = mutationPolicy;
@@ -70,7 +70,7 @@ public AbstractGeneticAlgorithm(final CrossoverPolicy<P> crossoverPolicy, final
      * @param selectionPolicy The {@link SelectionPolicy}
      * @param elitismRate     The elitism rate
      */
-    public AbstractGeneticAlgorithm(final CrossoverPolicy<P> crossoverPolicy, final MutationPolicy<P> mutationPolicy,
+    protected AbstractGeneticAlgorithm(final CrossoverPolicy<P> crossoverPolicy, final MutationPolicy<P> mutationPolicy,
             final SelectionPolicy<P> selectionPolicy, double elitismRate) {
         this.crossoverPolicy = crossoverPolicy;
         this.mutationPolicy = mutationPolicy;

commons-math4-genetics/src/main/java/org/apache/commons/math4/genetics/chromosome/AbstractChromosome.java

@@ -51,7 +51,7 @@ public abstract class AbstractChromosome<P> implements Chromosome<P> {
      * @param fitnessFunction The {@link FitnessFunction}
      * @param decoder         The {@link Decoder}
      */
-    public AbstractChromosome(final FitnessFunction<P> fitnessFunction, final Decoder<P> decoder) {
+    protected AbstractChromosome(final FitnessFunction<P> fitnessFunction, final Decoder<P> decoder) {
         ValidationUtils.checkForNull("fitness-function", fitnessFunction);
         ValidationUtils.checkForNull("decoder", decoder);
         this.fitnessFunction = fitnessFunction;

commons-math4-genetics/src/main/java/org/apache/commons/math4/genetics/chromosome/AbstractListChromosome.java

@@ -46,7 +46,7 @@ public abstract class AbstractListChromosome<T, P> extends AbstractChromosome<P>
      * @param decoder         An instance of {@link AbstractListChromosomeDecoder},
      *                        to decode list chromosome.
      */
-    public AbstractListChromosome(final List<T> representation, final FitnessFunction<P> fitnessFunction,
+    protected AbstractListChromosome(final List<T> representation, final FitnessFunction<P> fitnessFunction,
             final AbstractListChromosomeDecoder<T, P> decoder) {
         this(representation, true, fitnessFunction, decoder);
     }
@@ -59,7 +59,7 @@ public AbstractListChromosome(final List<T> representation, final FitnessFunctio
      * @param decoder         An instance of {@link AbstractListChromosomeDecoder},
      *                        to decode list chromosome.
      */
-    public AbstractListChromosome(final T[] representation, FitnessFunction<P> fitnessFunction,
+    protected AbstractListChromosome(final T[] representation, FitnessFunction<P> fitnessFunction,
             AbstractListChromosomeDecoder<T, P> decoder) {
         this(Arrays.asList(representation), fitnessFunction, decoder);
     }
@@ -73,7 +73,7 @@ public AbstractListChromosome(final T[] representation, FitnessFunction<P> fitne
      * @param fitnessFunction The {@link FitnessFunction}
      * @param decoder         The instance of {@link AbstractListChromosomeDecoder}
      */
-    public AbstractListChromosome(final List<T> representation, final boolean copyList,
+    protected AbstractListChromosome(final List<T> representation, final boolean copyList,
             final FitnessFunction<P> fitnessFunction, final AbstractListChromosomeDecoder<T, P> decoder) {
         super(fitnessFunction, decoder);
         ValidationUtils.checkForNull("representation", representation);

commons-math4-genetics/src/main/java/org/apache/commons/math4/genetics/chromosome/BinaryChromosome.java

@@ -56,7 +56,7 @@ public BinaryChromosome(Integer[] representation, FitnessFunction<P> fitnessFunc
      */
     @Override
     public BinaryChromosome<P> newChromosome(List<Integer> chromosomeRepresentation) {
-        return new BinaryChromosome<P>(chromosomeRepresentation, getFitnessFunction(), getDecoder());
+        return new BinaryChromosome<>(chromosomeRepresentation, getFitnessFunction(), getDecoder());
     }
 
     /**

commons-math4-genetics/src/main/java/org/apache/commons/math4/genetics/chromosome/IntegralValuedChromosome.java

@@ -104,7 +104,7 @@ private void checkValidity() {
      */
     @Override
     public IntegralValuedChromosome<P> newChromosome(List<Integer> chromosomeRepresentation) {
-        return new IntegralValuedChromosome<P>(chromosomeRepresentation, getFitnessFunction(), getDecoder(), this.min,
+        return new IntegralValuedChromosome<>(chromosomeRepresentation, getFitnessFunction(), getDecoder(), this.min,
                 this.max);
     }
 

commons-math4-genetics/src/main/java/org/apache/commons/math4/genetics/chromosome/RealValuedChromosome.java

@@ -129,7 +129,7 @@ private void checkValidity() {
      */
     @Override
     public RealValuedChromosome<P> newChromosome(List<Double> chromosomeRepresentation) {
-        return new RealValuedChromosome<P>(chromosomeRepresentation, getFitnessFunction(), getDecoder(), this.min,
+        return new RealValuedChromosome<>(chromosomeRepresentation, getFitnessFunction(), getDecoder(), this.min,
                 this.max);
     }
 
@@ -146,7 +146,7 @@ public RealValuedChromosome<P> newChromosome(List<Double> chromosomeRepresentati
      */
     public static <P> RealValuedChromosome<P> randomChromosome(int length, FitnessFunction<P> fitnessFunction,
             AbstractListChromosomeDecoder<Double, P> decoder, double min, double max) {
-        return new RealValuedChromosome<P>(ChromosomeRepresentationUtils.randomDoubleRepresentation(length, min, max),
+        return new RealValuedChromosome<>(ChromosomeRepresentationUtils.randomDoubleRepresentation(length, min, max),
                 fitnessFunction, decoder, min, max);
     }
 

commons-math4-genetics/src/main/java/org/apache/commons/math4/genetics/convergencecond/StoppingCondition.java

@@ -29,7 +29,7 @@ public interface StoppingCondition<P> {
     /**
      * Determine whether or not the given population satisfies the stopping
      * condition.
-     * @param population TODO
+     * @param population population of chromosome
      *
      * @return <code>true</code> if this stopping condition is met by the given
      *         population, <code>false</code> otherwise.

commons-math4-genetics/src/main/java/org/apache/commons/math4/genetics/crossover/rategenerator/package-info.java

@@ -197,7 +197,7 @@ public Population<P> nextGeneration(final double elitismRate) {
 
         if (oldChromosomes.size() * elitismRate == 0) {
             // if no of elite chromosome is 0 crete and return an empty population instance.
-            return new ListPopulation<P>(getPopulationLimit());
+            return new ListPopulation<>(getPopulationLimit());
         } else {
             // create a new generation of chromosomes with same parameters and add the elit
             // individuals.