@@ -182,8 +182,7 @@ public HappyEyeballsV2AsyncClientConnectionOperator(final DnsResolver dnsResolve
182182 final int attemptDelayMillis ) {
183183 this .dnsResolver = Args .notNull (dnsResolver , "DNS resolver" );
184184 this .attemptDelayMillis = attemptDelayMillis ;
185- this .otherFamilyDelayMillis =
186- Math .min (DEFAULT_OTHER_FAMILY_DELAY_MS , attemptDelayMillis );
185+ this .otherFamilyDelayMillis = Math .min (DEFAULT_OTHER_FAMILY_DELAY_MS , attemptDelayMillis );
187186
188187 final ThreadFactory tf = r -> {
189188 final Thread t = new Thread (r , "hc-hev2-scheduler" );
@@ -437,37 +436,63 @@ private static int compareByRFC6724(final ByRFC6724Info a,
437436 /* Rule 1 – unusable destinations */
438437 final boolean validA = sa != null && !sa .isAnyLocalAddress ();
439438 final boolean validB = sb != null && !sb .isAnyLocalAddress ();
440- if (!validA && !validB ) return 0 ;
441- if (!validB ) return preferA ;
442- if (!validA ) return preferB ;
439+ if (!validA && !validB ) {
440+ return 0 ;
441+ }
442+ if (!validB ) {
443+ return preferA ;
444+ }
445+ if (!validA ) {
446+ return preferB ;
447+ }
443448
444449 /* Rule 2 – prefer matching scope */
445- if (aDest .scope == aSrc .scope && bDest .scope != bSrc .scope ) return preferA ;
446- if (aDest .scope != aSrc .scope && bDest .scope == bSrc .scope ) return preferB ;
450+ if (aDest .scope == aSrc .scope && bDest .scope != bSrc .scope ) {
451+ return preferA ;
452+ }
453+ if (aDest .scope != aSrc .scope && bDest .scope == bSrc .scope ) {
454+ return preferB ;
455+ }
447456
448457 /* Rule 3 – TODO deprecated */
449458 /* Rule 4 – TODO home vs care-of */
450459
451460 /* Rule 5 – prefer matching label */
452- if (aSrc .label == aDest .label && bSrc .label != bDest .label ) return preferA ;
453- if (aSrc .label != aDest .label && bSrc .label == bDest .label ) return preferB ;
461+ if (aSrc .label == aDest .label && bSrc .label != bDest .label ) {
462+ return preferA ;
463+ }
464+ if (aSrc .label != aDest .label && bSrc .label == bDest .label ) {
465+ return preferB ;
466+ }
454467
455468 /* Rule 6 – higher precedence */
456- if (aDest .precedence > bDest .precedence ) return preferA ;
457- if (aDest .precedence < bDest .precedence ) return preferB ;
469+ if (aDest .precedence > bDest .precedence ) {
470+ return preferA ;
471+ }
472+ if (aDest .precedence < bDest .precedence ) {
473+ return preferB ;
474+ }
458475
459476 /* Rule 7 – TODO native transport */
460477
461478 /* Rule 8 – smaller scope */
462- if (aDest .scope .value < bDest .scope .value ) return preferA ;
463- if (aDest .scope .value > bDest .scope .value ) return preferB ;
479+ if (aDest .scope .value < bDest .scope .value ) {
480+ return preferA ;
481+ }
482+ if (aDest .scope .value > bDest .scope .value ) {
483+ return preferB ;
484+ }
464485
465486 /* Rule 9 – longest matching prefix (IPv6 only) */
466487 if (da instanceof Inet6Address && db instanceof Inet6Address ) {
467488 final int commonA = commonPrefixLen (sa , da );
468489 final int commonB = commonPrefixLen (sb , db );
469- if (commonA > commonB ) return preferA ;
470- if (commonA < commonB ) return preferB ;
490+ if (commonA > commonB ) {
491+ return preferA ;
492+ }
493+ if (commonA < commonB ) {
494+ return preferB ;
495+ }
471496 }
472497
473498 /* Rule 10 – equal */
0 commit comments