Report LuceneDev4002 at the call site instead of the target method

Reporting on the target method declaration produced a non-local
diagnostic — the analyzer was visiting an InvocationExpressionSyntax
but raising the diagnostic on a syntax tree it had not visited. MSBuild
ran a full compilation and surfaced the warning, but the IDE's per-file
live analysis filtered it out, so the warning never appeared in the
editor.

Move the report to the DoesStackTraceContainMethod invocation. The
diagnostic is now local, shows up in the IDE, and opens the door to a
code fix at the call site. The message names the qualified target
(e.g. 'Target.Merge') so it remains clear which method needs the
attribute. Test span updated accordingly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: paulirwin

src/Lucene.Net.CodeAnalysis.Dev/LuceneDev4xxx/LuceneDev4002_StackTraceHelperNoInliningAnalyzer.cs

@@ -99,6 +99,12 @@ private static void AnalyzeInvocation(SyntaxNodeAnalysisContext ctx, INamedTypeS
             if (targetType is null)
                 return;
 
+            // Report once per call site if any matching method declaration in source
+            // is missing NoInlining. Locating the diagnostic on the invocation makes
+            // it a "local" diagnostic relative to the syntax tree the analyzer is
+            // visiting, which means the IDE surfaces it (compilation-wide non-local
+            // diagnostics are filtered out of live IDE analysis) and a code fix can
+            // be wired up in the future.
             foreach (var member in targetType.GetMembers(methodNameValue).OfType<IMethodSymbol>())
             {
                 if (member.MethodKind != MethodKind.Ordinary)
@@ -120,8 +126,9 @@ private static void AnalyzeInvocation(SyntaxNodeAnalysisContext ctx, INamedTypeS
 
                     ctx.ReportDiagnostic(Diagnostic.Create(
                         Descriptors.LuceneDev4002_MissingNoInlining,
-                        methodDecl.GetLocation(),
-                        methodDecl.Identifier.ValueText));
+                        invocation.GetLocation(),
+                        $"{targetType.Name}.{methodDecl.Identifier.ValueText}"));
+                    return;
                 }
             }
         }

src/Lucene.Net.CodeAnalysis.Dev/Resources.resx

@@ -436,7 +436,7 @@ under the License.
     <value>If a method is referenced by StackTraceHelper.DoesStackTraceContainMethod and the JIT inlines it, the method will not appear in the stack trace and the check will silently fail. Apply [MethodImpl(MethodImplOptions.NoInlining)] to the method.</value>
   </data>
   <data name="LuceneDev4002_AnalyzerMessageFormat" xml:space="preserve">
-    <value>'{0}' is referenced by StackTraceHelper.DoesStackTraceContainMethod and should be marked with [MethodImpl(MethodImplOptions.NoInlining)] to prevent the JIT from inlining it out of the stack trace.</value>
+    <value>'{0}' is referenced by this StackTraceHelper.DoesStackTraceContainMethod call and should be marked with [MethodImpl(MethodImplOptions.NoInlining)] to prevent the JIT from inlining it out of the stack trace.</value>
   </data>
 
 </root>

tests/Lucene.Net.CodeAnalysis.Dev.Tests/LuceneDev4xxx/TestLuceneDev4002_StackTraceHelperNoInliningAnalyzer.cs

@@ -64,10 +64,13 @@ public void Check()
     }
 }" + StackTraceHelperStub;
 
+            // Diagnostic is now reported on the DoesStackTraceContainMethod invocation
+            // (call site) so the IDE can surface it and a future code fix can be hooked
+            // up. Argument is the qualified target method name.
             var expected = new DiagnosticResult(Descriptors.LuceneDev4002_MissingNoInlining)
                 .WithSeverity(DiagnosticSeverity.Warning)
-                .WithSpan(4, 5, 7, 6)
-                .WithArguments("Merge");
+                .WithSpan(14, 13, 14, 132)
+                .WithArguments("Target.Merge");
 
             var test = new InjectableCSharpAnalyzerTest(() => new LuceneDev4002_StackTraceHelperNoInliningAnalyzer())
             {