Skip to content

Commit ed24634

Browse files
committed
Updated issue templates for NB 25 rc phase + update PR template
- added number prefixes for template ordering purposes - added merge/approval checklist to PR template
1 parent b63567b commit ed24634

4 files changed

Lines changed: 16 additions & 1 deletion

File tree

.github/ISSUE_TEMPLATE/netbeans_bug_report.yml renamed to .github/ISSUE_TEMPLATE/01-netbeans_bug_report.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ body:
2828
multiple: false
2929
options:
3030
- "Apache NetBeans 24"
31-
# - "Apache NetBeans 25 release candidate"
31+
- "Apache NetBeans 25 release candidate"
3232
- "Apache NetBeans latest daily build"
3333
validations:
3434
required: true
@@ -73,6 +73,7 @@ body:
7373
multiple: false
7474
options:
7575
- "No / Don't know"
76+
- "Apache NetBeans 25"
7677
- "Apache NetBeans 24"
7778
- "Apache NetBeans 23"
7879
- "Apache NetBeans 22"
File renamed without changes.

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
---
66
**^Add meaningful description above**
77

8+
<details open>
9+
<summary>Click to collapse/expand PR instructions</summary>
10+
811
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
912

1013
- are all your own work, and you have the right to contribute them.
@@ -15,3 +18,14 @@ Please make sure (eg. `git log`) that all commits have a valid name and email ad
1518
If you're a first time contributor, see the Contributing guidelines for more information.
1619

1720
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
21+
22+
### PR approval and merge checklist:
23+
24+
1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run?
25+
2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
26+
3. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates?
27+
3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?
28+
29+
If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
30+
31+
</details>

0 commit comments

Comments
 (0)