PDFBOX-5660: annotate for Sonar after review

Maruan Sahyoun · Maruan Sahyoun · commit 4584e8c9096e · 2026-04-10T13:27:23.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1932963 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/fontbox/src/main/java/org/apache/fontbox/ttf/RandomAccessReadDataStream.java b/fontbox/src/main/java/org/apache/fontbox/ttf/RandomAccessReadDataStream.java
@@ -185,11 +185,13 @@ public int read(byte[] b, int off, int len) throws IOException
     }
 
     @Override
+    @SuppressWarnings("java:S2095") // buffer is intentionally not closed, must remain alive for the lifetime of the view
     public RandomAccessRead createSubView(long length)
     {
         try
         {
-            return new RandomAccessReadBuffer(data).createView(currentPosition, length);
+            RandomAccessReadBuffer buffer = new RandomAccessReadBuffer(data);
+            return buffer.createView(currentPosition, length);
         }
         catch (IOException e)
         {

Original file line number	Diff line number	Diff line change
`@@ -185,11 +185,13 @@ public int read(byte[] b, int off, int len) throws IOException`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`@Override`
	`188`	`+ @SuppressWarnings("java:S2095") // buffer is intentionally not closed, must remain alive for the lifetime of the view`
`188`	`189`	`public RandomAccessRead createSubView(long length)`
`189`	`190`	`{`
`190`	`191`	`try`
`191`	`192`	`{`
`192`		`- return new RandomAccessReadBuffer(data).createView(currentPosition, length);`
	`193`	`+ RandomAccessReadBuffer buffer = new RandomAccessReadBuffer(data);`
	`194`	`+ return buffer.createView(currentPosition, length);`
`193`	`195`	`}`
`194`	`196`	`catch (IOException e)`
`195`	`197`	`{`