Skip to content

Commit 6c14a3f

Browse files
committed
PDFBOX-2941: simplify code / remove catching exception that isn't thrown
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1933027 13f79535-47bb-0310-9956-ffa450edef68
1 parent 7ee080d commit 6c14a3f

2 files changed

Lines changed: 6 additions & 19 deletions

File tree

debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@
137137
import org.apache.pdfbox.debugger.ui.XrefEntry;
138138
import org.apache.pdfbox.debugger.ui.ZoomMenu;
139139
import org.apache.pdfbox.filter.FilterFactory;
140+
import org.apache.pdfbox.io.IOUtils;
140141
import org.apache.pdfbox.io.RandomAccessReadBuffer;
141142
import org.apache.pdfbox.pdmodel.PDDocument;
142143
import org.apache.pdfbox.pdmodel.common.PDPageLabels;
@@ -1290,23 +1291,12 @@ private String convertToString( Object selectedNode )
12901291

12911292
private void exitMenuItemActionPerformed(ActionEvent ignored)
12921293
{
1293-
if( document != null )
1294+
IOUtils.closeQuietly(document);
1295+
if (!currentFilePath.startsWith("http"))
12941296
{
1295-
try
1296-
{
1297-
document.close();
1298-
if (!currentFilePath.startsWith("http"))
1299-
{
1300-
recentFiles.addFile(currentFilePath);
1301-
}
1302-
recentFiles.close();
1303-
}
1304-
catch( IOException e )
1305-
{
1306-
// no dialogbox, don't interfere with exit wish
1307-
e.printStackTrace();
1308-
}
1297+
recentFiles.addFile(currentFilePath);
13091298
}
1299+
recentFiles.close();
13101300
windowPrefs.setExtendedState(getExtendedState());
13111301
this.setExtendedState(Frame.NORMAL);
13121302
windowPrefs.setBounds(getBounds());

debugger/src/main/java/org/apache/pdfbox/debugger/ui/RecentFiles.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package org.apache.pdfbox.debugger.ui;
1818

1919
import java.io.File;
20-
import java.io.IOException;
2120
import java.util.ArrayDeque;
2221
import java.util.ArrayList;
2322
import java.util.List;
@@ -117,10 +116,8 @@ public List<String> getFiles()
117116
/**
118117
* This method save the present recent file history in the preference. To get the recent file
119118
* history in next session this method must be called.
120-
*
121-
* @throws IOException if saving in preference doesn't success.
122119
*/
123-
public void close() throws IOException
120+
public void close()
124121
{
125122
writeHistoryToPref(filePaths);
126123
}

0 commit comments

Comments
 (0)