hrw: Refix loading geodb files (#13025)

* Restore old behavior to only call geo init with a geopath

* Split geo init from plugin init

Author: cmcfarlen

plugins/header_rewrite/header_rewrite.cc

@@ -41,15 +41,20 @@
 // Debugs
 namespace header_rewrite_ns
 {
-std::once_flag initHRWLibs;
+std::once_flag initGeoLibs;
+std::once_flag initPlugin;
 PluginFactory  plugin_factory;
 } // namespace header_rewrite_ns
 
 static void
-initHRWLibraries(const std::string &dbPath)
+initPluginFactory()
 {
   header_rewrite_ns::plugin_factory.setRuntimeDir(RecConfigReadRuntimeDir()).addSearchDir(RecConfigReadPluginDir());
+}
 
+static void
+initGeoLibraries(const std::string &dbPath)
+{
   if (dbPath.empty()) {
     return;
   }
@@ -597,7 +602,8 @@ TSPluginInit(int argc, const char *argv[])
 
   Dbg(pi_dbg_ctl, "Global geo db %s", geoDBpath.c_str());
 
-  std::call_once(initHRWLibs, [&geoDBpath]() { initHRWLibraries(geoDBpath); });
+  std::call_once(initGeoLibs, [&geoDBpath]() { initGeoLibraries(geoDBpath); });
+  std::call_once(initPlugin, initPluginFactory);
 
   // Parse the global config file(s). All rules are just appended
   // to the "global" Rules configuration.
@@ -705,17 +711,19 @@ TSRemapNewInstance(int argc, char *argv[], void **ih, char * /* errbuf ATS_UNUSE
     }
   }
 
-  if (!geoDBpath.empty() && !geoDBpath.starts_with('/')) {
-    geoDBpath = std::string(TSConfigDirGet()) + '/' + geoDBpath;
-  }
-
   if (!geoDBpath.empty()) {
+    if (!geoDBpath.starts_with('/')) {
+      geoDBpath = std::string(TSConfigDirGet()) + '/' + geoDBpath;
+    }
     Dbg(pi_dbg_ctl, "Remap geo db %s", geoDBpath.c_str());
+
+    // This MUST be called only if the geoDBpath is set.  If called without a geoDBPath (i.e. outside of this if) then
+    // NO hrw remap rule can load a mmdb file.
+    // The call_once applies to every remap instance as its a plugin global
+    std::call_once(initGeoLibs, [&geoDBpath]() { initGeoLibraries(geoDBpath); });
   }
 
-  // Always initialize the plugin factory, even if no geo DB is specified. This
-  // is needed for run-plugin to work with relative paths.
-  std::call_once(initHRWLibs, [&geoDBpath]() { initHRWLibraries(geoDBpath); });
+  std::call_once(initPlugin, initPluginFactory);
 
   auto *conf = new RulesConfig(timezone, inboundIpSource);