refactor(hooks): ensure notify-user hook only runs on success

Author: apiad

.gemini/hooks/journal.py

@@ -114,7 +114,8 @@ def main():
                 f"New changes detected: {', '.join(new_significant_changes[:3])}{'...' if len(new_significant_changes) > 3 else ''}.\n"
                 f"Please add or update a one-line entry to {journal_file} "
                 "describing the work you just did. Do not stop until this file is updated."
-            )
+            ),
+            continue_flag=False
         )
 
     except Exception as e:

.gemini/hooks/make.py

@@ -117,7 +117,7 @@ def main():
                 "```\n" + error_message.strip() + "\n```\n"
                 "Fix these issues and ensure 'make' passes before continuing."
             )
-            utils.send_hook_decision("deny", reason=fail_reason)
+            utils.send_hook_decision("deny", reason=fail_reason, continue_flag=False)
         else:
             # make passed
             update_last_run_timestamp()

.gemini/hooks/utils.py

@@ -58,7 +58,7 @@ def log_message(message, mode="a"):
     except Exception:
         pass
 
-def send_hook_decision(decision, reason=None, system_message=None, hook_output=None):
+def send_hook_decision(decision, reason=None, system_message=None, hook_output=None, continue_flag=None):
     """
     Prints the standard JSON response for a Gemini CLI hook.
     
@@ -67,6 +67,7 @@ def send_hook_decision(decision, reason=None, system_message=None, hook_output=N
         reason (str, optional): The reason for denial.
         system_message (str, optional): A system message to display to the user.
         hook_output (dict, optional): Additional context for the UI.
+        continue_flag (bool, optional): Whether the hook loop should continue.
     """
     response = {"decision": decision}
     if reason:
@@ -75,5 +76,7 @@ def send_hook_decision(decision, reason=None, system_message=None, hook_output=N
         response["systemMessage"] = system_message
     if hook_output:
         response["hookSpecificOutput"] = hook_output
+    if continue_flag is not None:
+        response["continue"] = continue_flag
 
     print(json.dumps(response))

.gemini/settings.json

@@ -76,7 +76,12 @@
             "name": "update-journal-and-changelog",
             "type": "command",
             "command": "python3 .gemini/hooks/journal.py"
-          },
+          }
+        ]
+      },
+      {
+        "matcher": "*",
+        "hooks": [
           {
             "name": "notify-user",
             "type": "command",