Commit e8b4d2d
fix: Fix serialization payload in Request. Fix Docs for Post Request (#683)
### Description
An incorrect serialization for `payload` is happening now. `payload` is
represented as a byte string, but bytes cannot be serialized to json.
Therefore, when loading and unloading from the queue
(`_persist_single_request_to_storage`, `_json_to_request`) we get
strings of format “b'test'”
Also corrected the documentation, as when filling forms the data should
be passed not in json format and have the appropriate header.
### Issues
- Closes: #668
### Testing
Updated `test_request_state_serialization` to also take `payload` into
account when serializing and deserializing `Request`
### Checklist
- [x] CI passed
---------
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>1 parent 33be41e commit e8b4d2d
4 files changed
Lines changed: 14 additions & 16 deletions
File tree
- docs/examples/code
- src/crawlee
- tests/unit/_memory_storage_client
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
| 11 | + | |
20 | 12 | | |
21 | 13 | | |
22 | 14 | | |
| |||
143 | 135 | | |
144 | 136 | | |
145 | 137 | | |
146 | | - | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
147 | 143 | | |
148 | 144 | | |
149 | 145 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | | - | |
103 | 102 | | |
104 | 103 | | |
105 | 104 | | |
106 | 105 | | |
107 | 106 | | |
108 | 107 | | |
| 108 | + | |
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
| |||
0 commit comments