add codestyle checks

Author: xxlabaza

.codestyle/pmd.xml

@@ -74,6 +74,7 @@ limitations under the License.
     <exclude name="MissingBreakInSwitch" />
   </rule>
   <rule ref="category/java/multithreading.xml">
+    <exclude name="DoNotUseThreads" />
   </rule>
   <rule ref="category/java/performance.xml">
     <exclude name="AvoidUsingShortType" />

client/src/main/java/io/appulse/epmd/java/client/CommandKill.java

@@ -23,6 +23,7 @@
 import io.appulse.epmd.java.core.model.request.Kill;
 import io.appulse.epmd.java.core.model.response.KillResult;
 import io.appulse.epmd.java.core.model.response.Response;
+
 import lombok.Builder;
 import lombok.extern.slf4j.Slf4j;
 import lombok.val;
@@ -61,6 +62,7 @@ public Boolean get () {
       val response = Response.parse(responseBytes, KillResult.class);
       return response == OK;
     } catch (Exception ex) {
+      log.error("Error during killing the EPMD server", ex);
       return false;
     }
   }

server/src/main/java/io/appulse/epmd/java/server/Epmd.java

@@ -28,32 +28,32 @@
 @NoArgsConstructor
 @AllArgsConstructor
 @Command(
-  name = "epmd",
-  description = "Erlang Port Mapper Daemon",
-  mixinStandardHelpOptions = true,
-  version = "epmd 2.0.0",
-  subcommands = {
-    SubcommandNames.class,
-    SubcommandServer.class,
-    SubcommandStop.class,
-    SubcommandKill.class
-  }
+    name = "epmd",
+    description = "Erlang Port Mapper Daemon",
+    mixinStandardHelpOptions = true,
+    version = "epmd 2.0.0",
+    subcommands = {
+      SubcommandNames.class,
+      SubcommandServer.class,
+      SubcommandStop.class,
+      SubcommandKill.class
+    }
 )
 class Epmd implements Runnable {
 
   @Option(
-    names = { "-p", "--port" },
-    paramLabel = "PORT",
-    description =
-      "Let epmd listen to another port than default ${DEFAULT-VALUE}. " +
-      "This can also be set using environment variable ERL_EPMD_PORT"
+      names = { "-p", "--port" },
+      paramLabel = "PORT",
+      description =
+        "Let epmd listen to another port than default ${DEFAULT-VALUE}. " +
+        "This can also be set using environment variable ERL_EPMD_PORT"
   )
   @Builder.Default
   int port = 4369;
 
   @Option(
-    names = { "-d", "--debug" },
-    description = "Enables debugging logs"
+      names = { "-d", "--debug" },
+      description = "Enables debugging logs"
   )
   boolean debug;
 

server/src/main/java/io/appulse/epmd/java/server/Main.java

@@ -16,11 +16,10 @@
 
 package io.appulse.epmd.java.server;
 
-import static java.util.Optional.ofNullable;
 import static java.util.Arrays.asList;
+import static java.util.Optional.ofNullable;
 
 import java.util.ArrayList;
-import java.util.List;
 
 import lombok.val;
 import picocli.CommandLine;

server/src/main/java/io/appulse/epmd/java/server/SubcommandKill.java

@@ -24,8 +24,8 @@
 
 import io.appulse.epmd.java.client.EpmdClient;
 
-import lombok.val;
 import lombok.extern.slf4j.Slf4j;
+import lombok.val;
 import picocli.CommandLine.Command;
 import picocli.CommandLine.ParentCommand;
 

server/src/main/java/io/appulse/epmd/java/server/SubcommandNames.java

@@ -1,17 +1,33 @@
+/*
+ * Copyright 2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 package io.appulse.epmd.java.server;
 
-import static java.util.stream.Collectors.joining;
 import static java.util.Locale.ENGLISH;
 import static java.util.concurrent.TimeUnit.SECONDS;
+import static java.util.stream.Collectors.joining;
 
 import java.util.concurrent.CompletionException;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.TimeoutException;
 
 import io.appulse.epmd.java.client.EpmdClient;
 
-import lombok.val;
 import lombok.extern.slf4j.Slf4j;
+import lombok.val;
 import picocli.CommandLine.Command;
 import picocli.CommandLine.ParentCommand;
 

server/src/main/java/io/appulse/epmd/java/server/SubcommandServer.java

@@ -18,12 +18,12 @@
 
 import static ch.qos.logback.classic.Level.DEBUG;
 import static java.util.Arrays.asList;
-import static java.util.stream.Collectors.toList;
-import static java.util.concurrent.TimeUnit.MILLISECONDS;
-import static java.util.concurrent.TimeUnit.SECONDS;
-import static java.util.Optional.of;
 import static java.util.Optional.empty;
+import static java.util.Optional.of;
 import static java.util.Optional.ofNullable;
+import static java.util.concurrent.TimeUnit.MILLISECONDS;
+import static java.util.concurrent.TimeUnit.SECONDS;
+import static java.util.stream.Collectors.toSet;
 import static org.slf4j.Logger.ROOT_LOGGER_NAME;
 
 import java.io.Closeable;
@@ -54,29 +54,30 @@
 import io.appulse.epmd.java.core.model.request.Request;
 import io.appulse.epmd.java.core.model.request.Stop;
 import io.appulse.epmd.java.core.model.response.EpmdDump;
+import io.appulse.epmd.java.core.model.response.EpmdDump.NodeDump;
 import io.appulse.epmd.java.core.model.response.EpmdInfo;
+import io.appulse.epmd.java.core.model.response.EpmdInfo.NodeDescription;
 import io.appulse.epmd.java.core.model.response.KillResult;
 import io.appulse.epmd.java.core.model.response.NodeInfo;
 import io.appulse.epmd.java.core.model.response.RegistrationResult;
 import io.appulse.epmd.java.core.model.response.Response;
 import io.appulse.epmd.java.core.model.response.StopResult;
-import io.appulse.epmd.java.core.model.response.EpmdDump.NodeDump;
-import io.appulse.epmd.java.core.model.response.EpmdInfo.NodeDescription;
 import io.appulse.utils.BytesUtils;
 import io.appulse.utils.SocketUtils;
 import io.appulse.utils.threads.AppulseExecutors;
 import io.appulse.utils.threads.AppulseThreadFactory;
 
 import ch.qos.logback.classic.Logger;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import lombok.Builder;
-import lombok.extern.slf4j.Slf4j;
 import lombok.NoArgsConstructor;
 import lombok.NonNull;
 import lombok.RequiredArgsConstructor;
 import lombok.Singular;
 import lombok.SneakyThrows;
-import lombok.val;
 import lombok.Value;
+import lombok.extern.slf4j.Slf4j;
+import lombok.val;
 import org.slf4j.LoggerFactory;
 import picocli.CommandLine.Command;
 import picocli.CommandLine.Option;
@@ -96,7 +97,7 @@ class SubcommandServer implements Runnable {
       ANY_ADDRESS = InetAddress.getByName("0.0.0.0");
       LOOPBACK_ADDRESS = InetAddress.getLoopbackAddress();
     } catch (UnknownHostException ex) {
-      throw new RuntimeException(ex);
+      throw new IllegalStateException(ex);
     }
   }
 
@@ -128,27 +129,27 @@ class SubcommandServer implements Runnable {
   }
 
   private void setupEnvironmentVariables () {
-    ips.add(LOOPBACK_ADDRESS);
-    if (ips.size() == 1) {
+    if (new SubcommandServer().ips.equals(ips)) {
       ips = ofNullable(System.getProperty("ERL_EPMD_ADDRESS"))
-          .map(it -> it.split(",\\s*"))
+          .map(it -> it.split(","))
           .map(it -> Stream.of(it)
+              .map(String::trim)
+              .filter(ip -> !ip.isEmpty())
               .map(ip -> {
                 try {
                   return InetAddress.getByName(ip);
                 } catch (UnknownHostException ex) {
-                  return null;
+                  throw new IllegalArgumentException("Invalid host " + ip, ex);
                 }
               })
-              .collect(toList()))
-          .map(HashSet::new)
-          .map(it -> (Set<InetAddress>) it)
+              .collect(toSet()))
           .map(it -> {
             it.add(LOOPBACK_ADDRESS);
             return it;
           })
           .orElse(ips);
     }
+    ips.add(LOOPBACK_ADDRESS);
 
     if (!unsafe) {
       val string = ofNullable(System.getProperty("ERL_EPMD_RELAXED_COMMAND_CHECK"))
@@ -160,6 +161,7 @@ private void setupEnvironmentVariables () {
 
   @Override
   @SneakyThrows
+  @SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
   public void run () {
     setupEnvironmentVariables();
 
@@ -205,7 +207,7 @@ public void run () {
         log.debug("{} - a new incoming connection", remoteSocketAddress);
 
         val handler = new ServerHandler(clientSocket);
-        executor.submit(handler);
+        executor.execute(handler);
       }
     } finally {
       executor.shutdown();
@@ -250,7 +252,7 @@ public void run () {
               return it;
             })
             .ifPresent(RequestProcessor::process);
-      } catch (Throwable ex) {
+      } catch (Exception ex) {
         if (options.debug) {
           log.error("handling {} connection error - '{}'", ex.getMessage(), ex);
         } else {
@@ -259,20 +261,20 @@ public void run () {
       }
     }
 
-    private Optional<RequestProcessor<?>> findProcessor (Request request, Socket socket) {
+    private Optional<RequestProcessor<?>> findProcessor (Request request, Socket clientSocket) {
       switch (request.getTag()) {
       case ALIVE2_REQUEST:
-        return of(new RegistrationRequestProcessor(request, socket));
+        return of(new RegistrationRequestProcessor(request, clientSocket));
       case DUMP_REQUEST:
-        return of(new DumpRequestProcessor(request, socket));
+        return of(new DumpRequestProcessor(request, clientSocket));
       case KILL_REQUEST:
-        return of(new KillRequestProcessor(request, socket));
+        return of(new KillRequestProcessor(request, clientSocket));
       case PORT_PLEASE2_REQUEST:
-        return of(new GetNodeInfoRequestProcessor(request, socket));
+        return of(new GetNodeInfoRequestProcessor(request, clientSocket));
       case NAMES_REQUEST:
-        return of(new GetEpmdInfoRequestProcessor(request, socket));
+        return of(new GetEpmdInfoRequestProcessor(request, clientSocket));
       case STOP_REQUEST:
-        return of(new StopRequestProcessor(request, socket));
+        return of(new StopRequestProcessor(request, clientSocket));
       default:
         log.warn("unsupported request's tag - {}", request.getTag());
         return empty();
@@ -395,13 +397,7 @@ protected Response respond () {
         if (!unsafe) {
           return KillResult.NOK;
         }
-        nodes.values().forEach(it -> {
-          try {
-            it.getSocket().close();
-          } catch (IOException ex) {
-            // noop
-          }
-        });
+        nodes.values().forEach(Node::close);
         return KillResult.OK;
       }
 
@@ -513,6 +509,7 @@ private static class Node implements Closeable {
     Socket socket;
 
     @Override
+    @SuppressWarnings("PMD.EmptyCatchBlock")
     public void close () {
       try {
         socket.close();
@@ -522,12 +519,13 @@ public void close () {
     }
 
     @SneakyThrows
+    @SuppressFBWarnings("REC_CATCH_EXCEPTION")
     boolean isAlive () {
       val nodeSocketAddress = new InetSocketAddress(socket.getInetAddress(), port);
       try (val nodeSocket = new Socket()) {
         nodeSocket.connect(nodeSocketAddress, 2_000);
         nodeSocket.close();
-      } catch (Throwable ex) {
+      } catch (Exception ex) {
         return false;
       }
       return true;

server/src/main/java/io/appulse/epmd/java/server/SubcommandStop.java

@@ -24,8 +24,8 @@
 
 import io.appulse.epmd.java.client.EpmdClient;
 
-import lombok.val;
 import lombok.extern.slf4j.Slf4j;
+import lombok.val;
 import picocli.CommandLine.Command;
 import picocli.CommandLine.Parameters;
 import picocli.CommandLine.ParentCommand;

server/src/test/java/io/appulse/epmd/java/server/SubcommandServerTests.java

@@ -33,13 +33,13 @@
 import io.appulse.epmd.java.client.EpmdClient;
 import io.appulse.epmd.java.client.exception.EpmdRegistrationException;
 import io.appulse.epmd.java.core.model.request.Registration;
-import io.appulse.epmd.java.core.model.response.NodeInfo;
 import io.appulse.epmd.java.core.model.response.EpmdDump.NodeDump;
+import io.appulse.epmd.java.core.model.response.NodeInfo;
 import io.appulse.utils.SocketUtils;
 import io.appulse.utils.threads.AppulseExecutors;
 
-import lombok.val;
 import lombok.extern.slf4j.Slf4j;
+import lombok.val;
 
 import org.assertj.core.api.SoftAssertions;
 import org.junit.jupiter.api.AfterEach;