linted

Author: chrisns

index.ts

@@ -1,7 +1,7 @@
 import { getGithubUsersFromGoogle } from './src/google'
 import { getGithubUsersFromGithub, addUsersToGitHubOrg, removeUsersToGitHubOrg } from './src/github'
 
-export async function run() {
+export async function run(): Promise<void> {
   const googleUsers = await getGithubUsersFromGoogle()
   console.log(`Users from google: ${Array.from(googleUsers).join(', ')}`)
 

src/github.ts

@@ -4,6 +4,7 @@ const ignoredUsers = process.env.IGNORED_USERS.toLowerCase().split(',')
 
 const octokit = getAuthenticatedOctokit()
 
+// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export function getAuthenticatedOctokit() {
   return new Octokit({
     authStrategy: createAppAuth,
@@ -15,7 +16,7 @@ export function getAuthenticatedOctokit() {
   })
 }
 
-export async function getGithubUsersFromGithub() {
+export async function getGithubUsersFromGithub(): Set<string> {
   const members = await octokit.paginate(octokit.orgs.listMembers, {
     org: process.env.GITHUB_ORG,
   })
@@ -33,11 +34,12 @@ export async function getGithubUsersFromGithub() {
   return new Set([...githubAccounts, ...pendingGithubAccounts])
 }
 
+// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export function formatUserList(users): Set<string> {
   return new Set(users.map((user) => user.login.toLowerCase()))
 }
 
-export async function getUserIdFromUsername(username: string) {
+export async function getUserIdFromUsername(username: string): Promise<number> {
   console.log(`Looking up user ${username}`)
   let user
   try {
@@ -49,13 +51,13 @@ export async function getUserIdFromUsername(username: string) {
   return user.data.id
 }
 
-export async function addUsersToGitHubOrg(users: Set<string>) {
+export async function addUsersToGitHubOrg(users: Set<string>): Promise<void> {
   for (const user of users) {
     await addUserToGitHubOrg(user)
   }
 }
 
-export async function addUserToGitHubOrg(user: string) {
+export async function addUserToGitHubOrg(user: string): Promise<void> {
   if (ignoredUsers.includes(user.toLowerCase())) {
     console.log(`Ignoring add for ${user}`)
     return false
@@ -69,12 +71,13 @@ export async function addUserToGitHubOrg(user: string) {
   console.log(`Invitation sent to ${user} (${userId} to ${process.env.GITHUB_ORG})`)
 }
 
-export async function removeUsersToGitHubOrg(users: Set<string>) {
+export async function removeUsersToGitHubOrg(users: Set<string>): Promise<void> {
   for (const user of users) {
     await removeUserToGitHubOrg(user)
   }
 }
 
+// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export async function removeUserToGitHubOrg(user: string) {
   if (ignoredUsers.includes(user.toLowerCase())) {
     console.log(`Ignoring remove for ${user}`)

src/google.ts

@@ -1,8 +1,9 @@
-const { google } = require('googleapis')
+import { google } from 'googleapis'
 
 const privatekey = JSON.parse(Buffer.from(process.env.GOOGLE_CREDENTIALS, 'base64').toString('utf-8'))
 
-export const googleAuth = async () => {
+// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
+export async function googleAuth() {
   const jwtClient = new google.auth.JWT(
     privatekey.client_email,
     null,
@@ -14,14 +15,15 @@ export const googleAuth = async () => {
   return jwtClient
 }
 
+// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export async function getAdminService() {
   return google.admin({
     version: 'directory_v1',
     auth: await googleAuth(),
   })
 }
 
-export async function getGithubUsersFromGoogle() {
+export async function getGithubUsersFromGoogle(): Set<string> {
   const service = await getAdminService()
 
   const userList: {