feat(lint): enable useExhaustiveDependencies rule with suppressions

Enable the biome correctness/useExhaustiveDependencies lint rule (was
previously "off"). All existing violations are suppressed with
biome-ignore comments added via `biome lint --suppress`.

Co-authored-by: Claude <noreply@anthropic.com>

https://claude.ai/code/session_01EHt5dM7Rts48s8HzcCaZCz

Author: claude

biome.json

@@ -41,7 +41,7 @@
         "noUnusedFunctionParameters": "off",
         "noUnusedImports": "off",
         "noUnusedVariables": "off",
-        "useExhaustiveDependencies": "off",
+        "useExhaustiveDependencies": "warn",
         "useHookAtTopLevel": "off",
         "useJsxKeyInIterable": "off",
         "useParseIntRadix": "off"

src/Apps/Article/Components/ArticleHTML.tsx

@@ -87,6 +87,7 @@ export const ArticleHTML: FC<React.PropsWithChildren<ArticleHTMLProps>> = ({
 
   const [transformed, setTransformed] = useState<string | null>(null)
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ignored using `--suppress`
   useEffect(() => {
     // Relies on the DOMParser global being available in the browser.
     import("@artsy/react-html-parser").then(({ default: reactHtmlParser }) => {

src/Apps/Article/Components/ArticleZoomGallery/ArticleZoomGalleryFigure.tsx

@@ -179,6 +179,7 @@ const Image: FC<
 
   const ref = useRef<HTMLImageElement>(null)
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ignored using `--suppress`
   useEffect(() => {
     if (ref.current?.complete) {
       setMode("Ready")

src/Apps/Artist/Routes/AuctionResults/Components/AuctionFilterMobileActionSheet.tsx

@@ -32,6 +32,7 @@ export const AuctionFilterMobileActionSheet: FC<
     filterContext.stagedFilters,
   )
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ignored using `--suppress`
   useEffect(() => {
     // While mobile sheet is mounted, the effect of the user's filter selections
     // should be merely staged until the Apply button is pressed, rather than

src/Apps/Artist/Routes/AuctionResults/Components/AuctionFilters/KeywordFilter.tsx

@@ -15,14 +15,16 @@ export const KeywordFilter: React.FC<React.PropsWithChildren<unknown>> = () => {
     filterContext.setFilter?.("keyword", text)
   }
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ignored using `--suppress`
   const handleChangeText = useMemo(
     () => debounce(updateKeywordFilter, DEBOUNCE_DELAY),
     // FIXME:
     [filterContext],
   )
 
   // Stop the invocation of the debounced function after unmounting
-  useEffect(() => {
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ignored using `--suppress`
+    useEffect(() => {
     return () => handleChangeText?.cancel?.()
     // FIXME:
   }, [])

src/Apps/Artwork/ArtworkApp.tsx

@@ -105,7 +105,8 @@ export const ArtworkApp: React.FC<React.PropsWithChildren<Props>> = props => {
 
   // If the user is expecting a partner offer, require login and remove
   // the query param from the URL after login.
-  useEffect(() => {
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ignored using `--suppress`
+      useEffect(() => {
     const expectingPartnerOffer = !!match?.location?.query?.partner_offer_id
     const isLoggedIn = !!me
 

src/Apps/Artwork/Components/ArtworkErrorApp/ArtworkErrorApp.tsx

@@ -46,6 +46,7 @@ export const ArtworkErrorApp: React.FC<
     }
   }, [])
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ignored using `--suppress`
   useEffect(() => {
     trackPageview()
   }, [])

src/Apps/Artwork/Components/ArtworkSidebar/ArtworkSidebarAuctionInfoPolling.tsx

@@ -31,6 +31,7 @@ export const ArtworkSidebarAuctionPolling: React.FC<
   const isMounted = useRef(false)
   const tracking = useTracking()
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ignored using `--suppress`
   useEffect(() => {
     if (isMounted.current) {
       setCurrentBidChanged(true)

src/Apps/Artwork/Components/ArtworkVideoPlayer/ArtworkVideoPlayer.tsx

@@ -59,6 +59,7 @@ const ArtworkVideoPlayer: FC<
     }, 0)
   }
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ignored using `--suppress`
   useEffect(() => {
     window.addEventListener("blur", trackClickedPlayVideo)
 

src/Apps/Auction/AuctionApp.tsx

@@ -54,6 +54,7 @@ export const AuctionApp: React.FC<React.PropsWithChildren<AuctionAppProps>> = ({
 
   const isFullBleedHeaderFixed = !cascadingEndTimeIntervalMinutes
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ignored using `--suppress`
   useEffect(() => {
     tracking.auctionPageView({ sale, me })
   }, [])