Merge pull request #40 from DekuDesu/development

fixed typo causing all items to be always selected to be placed on mi…

Author: artyredd

MiniMapMod/MiniMapPlugin.cs

@@ -239,7 +239,7 @@ private void ScanStaticTypes()
                     if (token is null)
                     {
                         Log.LogDebug($"No {nameof(PurchaseInteraction)} component on {nameof(ChestBehavior)}. GameObject.name = {chest.gameObject.name}");
-                        return true;
+                        return false;
                     }
 
                     return token.Contains("CHEST") && token != "LUNAR_CHEST_CONTEXT" && token.Contains("STEALTH") == false;
@@ -301,7 +301,7 @@ private void ScanStaticTypes()
                 });
 
             // duplicators
-            RegisterMonobehaviorType<PurchaseInteraction>(InteractableKind.Printer, dynamicObject: false, 
+            RegisterMonobehaviorType<PurchaseInteraction>(InteractableKind.Printer, dynamicObject: false,
                 selector: shop => shop?.contextToken?.Contains("DUPLICATOR") ?? false);
 
             // barrels
@@ -378,7 +378,7 @@ private void RegisterMonobehaviorType<T>(InteractableKind kind, Func<T, bool> Ac
 
             Log.LogDebug($"Selected {selected.Count()} {kind}s");
 
-            RegisterMonobehaviours(found, kind, ActiveChecker, dynamicObject);
+            RegisterMonobehaviours(selected, kind, ActiveChecker, dynamicObject);
         }
 
         /// <summary>

MiniMapMod/Minimap.cs

@@ -74,7 +74,7 @@ public void SetRotation(Quaternion rotation)
 
         public RectTransform CreateIcon(InteractableKind type, Vector3 minimapPosition, ISpriteManager spriteManager)
         {
-            Sprite sprite = null;
+            Sprite sprite;
 
             try
             {
@@ -84,6 +84,8 @@ public RectTransform CreateIcon(InteractableKind type, Vector3 minimapPosition,
             {
                 Log.LogError($"Failed to get sprite for type {type}");
                 Log.LogError(e.Message);
+
+                return null;
             }
 
             GameObject icon = CreateIcon(type, sprite);