fixed lag and crash bug from using wrong texture in config

Author: artyredd

MiniMapLibrary/Sprites/SpriteManager.cs

@@ -12,6 +12,13 @@ public sealed class SpriteManager : IDisposable, ISpriteManager
     {
         private readonly Dictionary<string, Sprite> SpriteCache = new Dictionary<string, Sprite>();
 
+        private readonly ILogger logger;
+
+        public SpriteManager(ILogger logger)
+        {
+            this.logger = logger;
+        }
+
         public void Dispose()
         {
             SpriteCache.Clear();
@@ -49,7 +56,15 @@ public void Dispose()
             }
             else 
             {
-                throw new MissingComponentException($"MissingTextureException: {Path} does not exist within the streaming assets");
+                loaded = Resources.Load<Sprite>(Settings.Icons.Default);
+
+                if (loaded is null)
+                {
+                    logger.LogError($"Attempted to use default icon for non-existen texture at {Path} but default icon path of {Settings.Icons.Default} also failed to load from the streaming assets path.");
+                    return null;
+                }
+
+                SpriteCache.Add(Path, loaded);
             }
 
             return loaded;

MiniMapMod/MiniMapPlugin.cs

@@ -12,10 +12,10 @@
 
 namespace MiniMapMod
 {
-    [BepInPlugin("MiniMap", "Mini Map Mod", "3.2.0")]
+    [BepInPlugin("MiniMap", "Mini Map Mod", "3.2.1")]
     public class MiniMapPlugin : BaseUnityPlugin
     {
-        private readonly ISpriteManager SpriteManager = new SpriteManager();
+        private ISpriteManager SpriteManager;
 
         private readonly List<ITrackedObject> TrackedObjects = new();
 
@@ -40,6 +40,8 @@ public void Awake()
             // we can pass it to the business layer
             logger = new Log(base.Logger);
 
+            SpriteManager = new SpriteManager(logger);
+
             // create the minimap controller
             Minimap = new(logger);
 

README.md

@@ -76,14 +76,19 @@ Huge thanks to these awesome people who assisted in creating awesome features fo
 [Arcafanetiz](https://github.com/Arcafanetiz)
 
 ### Change Log
+Minor 3.2.1
+- fixed bug where chosing wrong icon path in config would lag and crash game with MissingTextureExceptions thrown by `SpriteManager.GetOrCache`
+
 Major 3.2
-- Re-implemented scanning framework for performance
+- Re-implemented entire scanning framework for performance to allow more dynamic types at runtime
 - Added Equipment Barrels
 - Added Shops
 - Added Void Enemies
+- Added Lunar Enemies
 - Added Players (non-client)
 - Added Allies (drones that have been bought)
 - Added Dropped Items / Lunar Coins
+- Fixed bug where the no meaningful stacktrace was being outputted to the log for user debugging
 
 Hotfix 3.1.6
 - fixed typo causing all objects on map being selected to be placed on minimap regardless if they were filtered out

manifest.json

@@ -1,6 +1,6 @@
 {
   "name": "MiniMapMod",
-  "version_number": "3.2.0",
+  "version_number": "3.2.1",
   "website_url": "https://github.com/DekuDesu",
   "description": "Adds a MiniMap to your game v3.2",
   "dependencies": [