Skip to content

Commit d05f4a4

Browse files
author
Ronen Hilewicz
committed
Remove test manifest
1 parent 3febe9f commit d05f4a4

3 files changed

Lines changed: 22 additions & 84 deletions

File tree

test/assets/manifest.yaml

Lines changed: 0 additions & 51 deletions
This file was deleted.

test/test_directory_v3.py

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -315,13 +315,10 @@ def test_find_subjects(directory: Directory):
315315
def test_get_manifest(directory: Directory):
316316
manifest = directory.get_manifest()
317317

318-
with open("test/assets/manifest.yaml", "rb") as f:
319-
expected = f.read()
320-
321318
assert manifest is not None
322319
assert manifest.etag
323320
assert manifest.updated_at.date() == datetime.datetime.now(datetime.UTC).date()
324-
assert manifest.body == expected
321+
assert manifest.body
325322

326323

327324
def test_get_manifest_not_modified(directory: Directory):
@@ -333,30 +330,28 @@ def test_get_manifest_not_modified(directory: Directory):
333330

334331

335332
def test_set_manifest(directory: Directory):
336-
with open("test/assets/manifest.yaml", "rb") as f:
337-
manifest = f.read()
333+
manifest = directory.get_manifest()
334+
assert manifest.body is not None
338335

339-
manifest += b"\n foo: {}"
336+
new_body = bytes(manifest.body) + b"\n foo: {}"
340337

341-
directory.set_manifest(manifest)
338+
directory.set_manifest(new_body)
342339

343340
new_manifest = directory.get_manifest()
344341

345-
assert new_manifest.body == manifest
342+
assert new_manifest.body == new_body
346343

347344

348345
def test_set_manifest_if_match(directory: Directory):
349-
with open("test/assets/manifest.yaml", "rb") as f:
350-
manifest = f.read()
346+
manifest = directory.get_manifest()
347+
assert manifest.body is not None
351348

352-
manifest += b"\n bar: {}"
349+
new_body = bytes(manifest.body) + b"\n bar: {}"
353350

354351
with pytest.raises(ETagMismatchError):
355-
directory.set_manifest(manifest, etag="1234")
356-
357-
current = directory.get_manifest()
352+
directory.set_manifest(new_body, etag="1234")
358353

359-
directory.set_manifest(manifest, etag=current.etag)
354+
directory.set_manifest(new_body, etag=manifest.etag)
360355

361356

362357
def test_import(directory: Directory):

test/test_directory_v3_async.py

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -341,13 +341,10 @@ async def test_find_subjects(directory: Directory):
341341
async def test_get_manifest(directory: Directory):
342342
manifest = await directory.get_manifest()
343343

344-
with open("test/assets/manifest.yaml", "rb") as f:
345-
expected = f.read()
346-
347344
assert manifest is not None
348345
assert manifest.etag
349346
assert manifest.updated_at.date() == datetime.datetime.now(datetime.UTC).date()
350-
assert manifest.body == expected
347+
assert manifest.body
351348

352349

353350
@pytest.mark.asyncio(scope="module")
@@ -361,31 +358,28 @@ async def test_get_manifest_not_modified(directory: Directory):
361358

362359
@pytest.mark.asyncio(scope="module")
363360
async def test_set_manifest(directory: Directory):
364-
with open("test/assets/manifest.yaml", "rb") as f:
365-
manifest = f.read()
366-
367-
manifest += b"\n baz: {}"
361+
manifest = await directory.get_manifest()
362+
assert manifest.body is not None
368363

369-
await directory.set_manifest(manifest)
364+
new_body = bytes(manifest.body) + b"\n foo: {}"
365+
await directory.set_manifest(new_body)
370366

371367
new_manifest = await directory.get_manifest()
372368

373-
assert new_manifest.body == manifest
369+
assert new_manifest.body == new_body
374370

375371

376372
@pytest.mark.asyncio(scope="module")
377373
async def test_set_manifest_if_match(directory: Directory):
378-
with open("test/assets/manifest.yaml", "rb") as f:
379-
manifest = f.read()
374+
manifest = await directory.get_manifest()
375+
assert manifest.body is not None
380376

381-
manifest += b"\n bam: {}"
377+
new_body = bytes(manifest.body) + b"\n bar: {}"
382378

383379
with pytest.raises(ETagMismatchError):
384-
await directory.set_manifest(manifest, etag="1234")
385-
386-
current = await directory.get_manifest()
380+
await directory.set_manifest(new_body, etag="1234")
387381

388-
await directory.set_manifest(manifest, etag=current.etag)
382+
await directory.set_manifest(new_body, etag=manifest.etag)
389383

390384

391385
@pytest.mark.asyncio(scope="module")

0 commit comments

Comments
 (0)